Revert of Patch to try dump-on-DCHECK.

Revert of Patch to try dump-on-DCHECK. (patchset #13 id:240001 of https://codereview.chromium.org/1814423002/ )

Reason for revert:
We have a Canary w/ dump-on-DCHECK - time to revert!

Original issue's description:
> Patch to try dump-on-DCHECK.
> 
> This patch does two things:
> 
> 1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the process, to only uploading a crash dump, and only on the first failed DCHECK in each process.
> 
> 2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.
> 
> All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is for DCHECKs to switch from no-ops to uploading dumps without crashing, in Windows official builds.
> 
> Note that this CL is intended to be landed, a branch cut to release from, and then immediately reverted; it is not intended to be landed in Chromium for any longer period.
> 
> BUG=596231
> 
> Committed: https://crrev.com/6436ac7ddec4b2b3aba4ee38aabe7dffe238a077
> Cr-Commit-Position: refs/heads/master@{#383894}
> 
> Committed: https://crrev.com/bac26c8a840909a679a5a74557fa6f4f60ae9e07
> Cr-Commit-Position: refs/heads/master@{#384011}
> 
> Committed: https://crrev.com/16502cb143f737bafad5d035b8ed6d76aabce288
> Cr-Commit-Position: refs/heads/master@{#384675}
> 
> Committed: https://crrev.com/b80aa8f5c269c9ee4f3a00b03840ea3df68f77d1
> Cr-Commit-Position: refs/heads/master@{#385413}

TBR=danakj@chromium.org,scottmg@chromium.org,thakis@chromium.org,hans@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=596231, 601551
Committed: https://chromium.googlesource.com/chromium/src/+/0c6faeb81f1461952b5c63ad33e9fccc021a0c95

[Wez, 2016-04-07 15:10:51]

Created Revert of Patch to try dump-on-DCHECK.

[commit-bot: I haz the power, 2016-04-07 15:11:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870633003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870633003/1

[commit-bot: I haz the power, 2016-04-07 15:31:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870633003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870633003/1

[commit-bot: I haz the power, 2016-04-07 16:01:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870633003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870633003/1

[commit-bot: I haz the power, 2016-04-07 16:31:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870633003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870633003/1

[commit-bot: I haz the power, 2016-04-07 17:01:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870633003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870633003/1

[commit-bot: I haz the power, 2016-04-07 17:31:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870633003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870633003/1

[Wez, 2016-04-07 17:39:09]

The CQ bit was unchecked by wez@chromium.org

[Wez, 2016-04-07 17:39:14]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2016-04-07 17:39:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870633003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870633003/1

[scottmg, 2016-04-07 19:15:20]

I will merge this to 2702 as soon as it lands.

[Wez, 2016-04-07 19:16:26]

Description was changed from

==========
Revert of Patch to try dump-on-DCHECK. (patchset #13 id:240001 of
https://codereview.chromium.org/1814423002/ )

Reason for revert:
We have a Canary w/ dump-on-DCHECK - time to revert!

Original issue's description:
> Patch to try dump-on-DCHECK.
> 
> This patch does two things:
> 
> 1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the
process, to only uploading a crash dump, and only on the first failed DCHECK in
each process.
> 
> 2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.
> 
> All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is
for DCHECKs to switch from no-ops to uploading dumps without crashing, in
Windows official builds.
> 
> Note that this CL is intended to be landed, a branch cut to release from, and
then immediately reverted; it is not intended to be landed in Chromium for any
longer period.
> 
> BUG=596231
> 
> Committed: https://crrev.com/6436ac7ddec4b2b3aba4ee38aabe7dffe238a077
> Cr-Commit-Position: refs/heads/master@{#383894}
> 
> Committed: https://crrev.com/bac26c8a840909a679a5a74557fa6f4f60ae9e07
> Cr-Commit-Position: refs/heads/master@{#384011}
> 
> Committed: https://crrev.com/16502cb143f737bafad5d035b8ed6d76aabce288
> Cr-Commit-Position: refs/heads/master@{#384675}
> 
> Committed: https://crrev.com/b80aa8f5c269c9ee4f3a00b03840ea3df68f77d1
> Cr-Commit-Position: refs/heads/master@{#385413}

TBR=danakj@chromium.org,scottmg@chromium.org,thakis@chromium.org,hans@chromiu...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=596231
==========

to

==========
Revert of Patch to try dump-on-DCHECK. (patchset #13 id:240001 of
https://codereview.chromium.org/1814423002/ )

Reason for revert:
We have a Canary w/ dump-on-DCHECK - time to revert!

Original issue's description:
> Patch to try dump-on-DCHECK.
> 
> This patch does two things:
> 
> 1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the
process, to only uploading a crash dump, and only on the first failed DCHECK in
each process.
> 
> 2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.
> 
> All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is
for DCHECKs to switch from no-ops to uploading dumps without crashing, in
Windows official builds.
> 
> Note that this CL is intended to be landed, a branch cut to release from, and
then immediately reverted; it is not intended to be landed in Chromium for any
longer period.
> 
> BUG=596231
> 
> Committed: https://crrev.com/6436ac7ddec4b2b3aba4ee38aabe7dffe238a077
> Cr-Commit-Position: refs/heads/master@{#383894}
> 
> Committed: https://crrev.com/bac26c8a840909a679a5a74557fa6f4f60ae9e07
> Cr-Commit-Position: refs/heads/master@{#384011}
> 
> Committed: https://crrev.com/16502cb143f737bafad5d035b8ed6d76aabce288
> Cr-Commit-Position: refs/heads/master@{#384675}
> 
> Committed: https://crrev.com/b80aa8f5c269c9ee4f3a00b03840ea3df68f77d1
> Cr-Commit-Position: refs/heads/master@{#385413}

TBR=danakj@chromium.org,scottmg@chromium.org,thakis@chromium.org,hans@chromiu...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=596231, 601551
==========

[Wez, 2016-04-07 19:16:31]

The CQ bit was unchecked by wez@chromium.org

[Wez, 2016-04-07 19:16:34]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2016-04-07 19:17:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870633003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870633003/1

[scottmg, 2016-04-07 19:23:01]

The CQ bit was unchecked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-04-07 19:25:35]

Description was changed from

==========
Revert of Patch to try dump-on-DCHECK. (patchset #13 id:240001 of
https://codereview.chromium.org/1814423002/ )

Reason for revert:
We have a Canary w/ dump-on-DCHECK - time to revert!

Original issue's description:
> Patch to try dump-on-DCHECK.
> 
> This patch does two things:
> 
> 1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the
process, to only uploading a crash dump, and only on the first failed DCHECK in
each process.
> 
> 2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.
> 
> All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is
for DCHECKs to switch from no-ops to uploading dumps without crashing, in
Windows official builds.
> 
> Note that this CL is intended to be landed, a branch cut to release from, and
then immediately reverted; it is not intended to be landed in Chromium for any
longer period.
> 
> BUG=596231
> 
> Committed: https://crrev.com/6436ac7ddec4b2b3aba4ee38aabe7dffe238a077
> Cr-Commit-Position: refs/heads/master@{#383894}
> 
> Committed: https://crrev.com/bac26c8a840909a679a5a74557fa6f4f60ae9e07
> Cr-Commit-Position: refs/heads/master@{#384011}
> 
> Committed: https://crrev.com/16502cb143f737bafad5d035b8ed6d76aabce288
> Cr-Commit-Position: refs/heads/master@{#384675}
> 
> Committed: https://crrev.com/b80aa8f5c269c9ee4f3a00b03840ea3df68f77d1
> Cr-Commit-Position: refs/heads/master@{#385413}

TBR=danakj@chromium.org,scottmg@chromium.org,thakis@chromium.org,hans@chromiu...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=596231, 601551
==========

to

==========
Revert of Patch to try dump-on-DCHECK. (patchset #13 id:240001 of
https://codereview.chromium.org/1814423002/ )

Reason for revert:
We have a Canary w/ dump-on-DCHECK - time to revert!

Original issue's description:
> Patch to try dump-on-DCHECK.
>
> This patch does two things:
>
> 1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the
process, to only uploading a crash dump, and only on the first failed DCHECK in
each process.
>
> 2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.
>
> All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is
for DCHECKs to switch from no-ops to uploading dumps without crashing, in
Windows official builds.
>
> Note that this CL is intended to be landed, a branch cut to release from, and
then immediately reverted; it is not intended to be landed in Chromium for any
longer period.
>
> BUG=596231
>
> Committed: https://crrev.com/6436ac7ddec4b2b3aba4ee38aabe7dffe238a077
> Cr-Commit-Position: refs/heads/master@{#383894}
>
> Committed: https://crrev.com/bac26c8a840909a679a5a74557fa6f4f60ae9e07
> Cr-Commit-Position: refs/heads/master@{#384011}
>
> Committed: https://crrev.com/16502cb143f737bafad5d035b8ed6d76aabce288
> Cr-Commit-Position: refs/heads/master@{#384675}
>
> Committed: https://crrev.com/b80aa8f5c269c9ee4f3a00b03840ea3df68f77d1
> Cr-Commit-Position: refs/heads/master@{#385413}

TBR=danakj@chromium.org,scottmg@chromium.org,thakis@chromium.org,hans@chromiu...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=596231, 601551

Committed: https://crrev.com/0c6faeb81f1461952b5c63ad33e9fccc021a0c95
Cr-Commit-Position: refs/heads/master@{#385835}
==========

[commit-bot: I haz the power, 2016-04-07 19:25:36]

Patchset 1 (id:??) landed as
https://crrev.com/0c6faeb81f1461952b5c63ad33e9fccc021a0c95
Cr-Commit-Position: refs/heads/master@{#385835}

[scottmg, 2016-04-07 19:26:16]

Description was changed from

==========
Revert of Patch to try dump-on-DCHECK. (patchset #13 id:240001 of
https://codereview.chromium.org/1814423002/ )

Reason for revert:
We have a Canary w/ dump-on-DCHECK - time to revert!

Original issue's description:
> Patch to try dump-on-DCHECK.
>
> This patch does two things:
>
> 1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the
process, to only uploading a crash dump, and only on the first failed DCHECK in
each process.
>
> 2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.
>
> All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is
for DCHECKs to switch from no-ops to uploading dumps without crashing, in
Windows official builds.
>
> Note that this CL is intended to be landed, a branch cut to release from, and
then immediately reverted; it is not intended to be landed in Chromium for any
longer period.
>
> BUG=596231
>
> Committed: https://crrev.com/6436ac7ddec4b2b3aba4ee38aabe7dffe238a077
> Cr-Commit-Position: refs/heads/master@{#383894}
>
> Committed: https://crrev.com/bac26c8a840909a679a5a74557fa6f4f60ae9e07
> Cr-Commit-Position: refs/heads/master@{#384011}
>
> Committed: https://crrev.com/16502cb143f737bafad5d035b8ed6d76aabce288
> Cr-Commit-Position: refs/heads/master@{#384675}
>
> Committed: https://crrev.com/b80aa8f5c269c9ee4f3a00b03840ea3df68f77d1
> Cr-Commit-Position: refs/heads/master@{#385413}

TBR=danakj@chromium.org,scottmg@chromium.org,thakis@chromium.org,hans@chromiu...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=596231, 601551

Committed: https://crrev.com/0c6faeb81f1461952b5c63ad33e9fccc021a0c95
Cr-Commit-Position: refs/heads/master@{#385835}
==========

to

==========
Revert of Patch to try dump-on-DCHECK. (patchset #13 id:240001 of
https://codereview.chromium.org/1814423002/ )

Reason for revert:
We have a Canary w/ dump-on-DCHECK - time to revert!

Original issue's description:
> Patch to try dump-on-DCHECK.
> 
> This patch does two things:
> 
> 1. Adds a flag to switch DCHECK from logging, dumping, and then crashing the
process, to only uploading a crash dump, and only on the first failed DCHECK in
each process.
> 
> 2. Forces that flag, and DCHECK_ALWAYS_ON, on in Windows official builds.
> 
> All non-debug e.g. CHECK behaviours remain unchanged; the intended effect is
for DCHECKs to switch from no-ops to uploading dumps without crashing, in
Windows official builds.
> 
> Note that this CL is intended to be landed, a branch cut to release from, and
then immediately reverted; it is not intended to be landed in Chromium for any
longer period.
> 
> BUG=596231
> 
> Committed: https://crrev.com/6436ac7ddec4b2b3aba4ee38aabe7dffe238a077
> Cr-Commit-Position: refs/heads/master@{#383894}
> 
> Committed: https://crrev.com/bac26c8a840909a679a5a74557fa6f4f60ae9e07
> Cr-Commit-Position: refs/heads/master@{#384011}
> 
> Committed: https://crrev.com/16502cb143f737bafad5d035b8ed6d76aabce288
> Cr-Commit-Position: refs/heads/master@{#384675}
> 
> Committed: https://crrev.com/b80aa8f5c269c9ee4f3a00b03840ea3df68f77d1
> Cr-Commit-Position: refs/heads/master@{#385413}

TBR=danakj@chromium.org,scottmg@chromium.org,thakis@chromium.org,hans@chromiu...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=596231, 601551

Committed:
https://chromium.googlesource.com/chromium/src/+/0c6faeb81f1461952b5c63ad33e9...
==========

[scottmg, 2016-04-07 19:26:18]

Committed patchset #1 (id:1) manually as
0c6faeb81f1461952b5c63ad33e9fccc021a0c95 (presubmit successful).

[scottmg, 2016-04-07 19:27:49]

Got impatient waiting on win_chromium_rel_ng. Drovering to 2702 now.