Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Side by Side Diff: build/common.gypi

Issue 1870633003: Revert of Patch to try dump-on-DCHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/logging_unittest.cc ('k') | build/config/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 704 matching lines...) Expand 10 before | Expand all | Expand 10 after
715 # Whether the entire browser uses toolkit-views on Mac instead of Cocoa. 715 # Whether the entire browser uses toolkit-views on Mac instead of Cocoa.
716 'mac_views_browser%': 0, 716 'mac_views_browser%': 0,
717 717
718 # By default, use ICU data file (icudtl.dat). 718 # By default, use ICU data file (icudtl.dat).
719 'icu_use_data_file_flag%': 1, 719 'icu_use_data_file_flag%': 1,
720 720
721 # Turn on JNI generation optimizations by default. 721 # Turn on JNI generation optimizations by default.
722 'optimize_jni_generation%': 1, 722 'optimize_jni_generation%': 1,
723 723
724 'conditions': [ 724 'conditions': [
725 # In Windows official builds, enable DCHECK as dump-without-crashing.
726 ['OS=="win" and buildtype=="Official"', {
727 'dcheck_always_on%': 1,
728 'dcheck_is_dump_without_crash': 1,
729 }, {
730 'dcheck_always_on%': 0,
731 'dcheck_is_dump_without_crash': 0,
732 }],
733
734 # A flag for POSIX platforms 725 # A flag for POSIX platforms
735 ['OS=="win"', { 726 ['OS=="win"', {
736 'os_posix%': 0, 727 'os_posix%': 0,
737 }, { 728 }, {
738 'os_posix%': 1, 729 'os_posix%': 1,
739 }], 730 }],
740 731
741 # A flag for BSD platforms 732 # A flag for BSD platforms
742 ['OS=="freebsd" or OS=="openbsd"', { 733 ['OS=="freebsd" or OS=="openbsd"', {
743 'os_bsd%': 1, 734 'os_bsd%': 1,
(...skipping 451 matching lines...) Expand 10 before | Expand all | Expand 10 after
1195 'is_cast_desktop_build%': '<(is_cast_desktop_build)', 1186 'is_cast_desktop_build%': '<(is_cast_desktop_build)',
1196 'enable_viewport%': '<(enable_viewport)', 1187 'enable_viewport%': '<(enable_viewport)',
1197 'enable_hidpi%': '<(enable_hidpi)', 1188 'enable_hidpi%': '<(enable_hidpi)',
1198 'enable_topchrome_md%': '<(enable_topchrome_md)', 1189 'enable_topchrome_md%': '<(enable_topchrome_md)',
1199 'enable_wayland_server%': '<(enable_wayland_server)', 1190 'enable_wayland_server%': '<(enable_wayland_server)',
1200 'enable_wifi_display%': '<(enable_wifi_display)', 1191 'enable_wifi_display%': '<(enable_wifi_display)',
1201 'image_loader_extension%': '<(image_loader_extension)', 1192 'image_loader_extension%': '<(image_loader_extension)',
1202 'fastbuild%': '<(fastbuild)', 1193 'fastbuild%': '<(fastbuild)',
1203 'win_z7%': '<(win_z7)', 1194 'win_z7%': '<(win_z7)',
1204 'dcheck_always_on%': '<(dcheck_always_on)', 1195 'dcheck_always_on%': '<(dcheck_always_on)',
1205 'dcheck_is_dump_without_crash%': '<(dcheck_is_dump_without_crash)',
1206 'tracing_like_official_build%': '<(tracing_like_official_build)', 1196 'tracing_like_official_build%': '<(tracing_like_official_build)',
1207 'fieldtrial_testing_like_official_build%': '<(fieldtrial_testing_like_offici al_build)', 1197 'fieldtrial_testing_like_official_build%': '<(fieldtrial_testing_like_offici al_build)',
1208 'arm_version%': '<(arm_version)', 1198 'arm_version%': '<(arm_version)',
1209 'arm_neon%': '<(arm_neon)', 1199 'arm_neon%': '<(arm_neon)',
1210 'arm_neon_optional%': '<(arm_neon_optional)', 1200 'arm_neon_optional%': '<(arm_neon_optional)',
1211 'sysroot%': '<(sysroot)', 1201 'sysroot%': '<(sysroot)',
1212 'use_sysroot%': '<(use_sysroot)', 1202 'use_sysroot%': '<(use_sysroot)',
1213 'pkg-config%': '<(pkg-config)', 1203 'pkg-config%': '<(pkg-config)',
1214 'chroot_cmd%': '<(chroot_cmd)', 1204 'chroot_cmd%': '<(chroot_cmd)',
1215 'system_libdir%': '<(system_libdir)', 1205 'system_libdir%': '<(system_libdir)',
(...skipping 1636 matching lines...) Expand 10 before | Expand all | Expand 10 after
2852 ['OS=="android" and fastbuild==1', { 2842 ['OS=="android" and fastbuild==1', {
2853 # TODO(thakis): Change this to -g1 once http://crbug.com/456947 is 2843 # TODO(thakis): Change this to -g1 once http://crbug.com/456947 is
2854 # fixed. 2844 # fixed.
2855 'variables': { 'release_extra_cflags': '-g0', }, 2845 'variables': { 'release_extra_cflags': '-g0', },
2856 }], 2846 }],
2857 ], 2847 ],
2858 }], # fastbuild!=0 2848 }], # fastbuild!=0
2859 ['dcheck_always_on!=0', { 2849 ['dcheck_always_on!=0', {
2860 'defines': ['DCHECK_ALWAYS_ON=1'], 2850 'defines': ['DCHECK_ALWAYS_ON=1'],
2861 }], # dcheck_always_on!=0 2851 }], # dcheck_always_on!=0
2862 ['dcheck_is_dump_without_crash!=0', {
2863 'defines': ['DCHECK_IS_DUMP_WITHOUT_CRASH=1'],
2864 }], # dcheck_is_dump_without_crash!=0
2865 ['tracing_like_official_build!=0', { 2852 ['tracing_like_official_build!=0', {
2866 'defines': ['TRACING_IS_OFFICIAL_BUILD=1'], 2853 'defines': ['TRACING_IS_OFFICIAL_BUILD=1'],
2867 }], # tracing_like_official_build!=0 2854 }], # tracing_like_official_build!=0
2868 ['fieldtrial_testing_like_official_build==0 and branding!="Chrome"', { 2855 ['fieldtrial_testing_like_official_build==0 and branding!="Chrome"', {
2869 'defines': ['FIELDTRIAL_TESTING_ENABLED'], 2856 'defines': ['FIELDTRIAL_TESTING_ENABLED'],
2870 }], # fieldtrial_testing_like_official_build==0 and branding!="Chrome" 2857 }], # fieldtrial_testing_like_official_build==0 and branding!="Chrome"
2871 ['OS=="win"', { 2858 ['OS=="win"', {
2872 'defines': ['NO_TCMALLOC'], 2859 'defines': ['NO_TCMALLOC'],
2873 'conditions': [ 2860 'conditions': [
2874 ['win_use_allocator_shim==1', { 2861 ['win_use_allocator_shim==1', {
(...skipping 3521 matching lines...) Expand 10 before | Expand all | Expand 10 after
6396 # settings in target dicts. SYMROOT is a special case, because many other 6383 # settings in target dicts. SYMROOT is a special case, because many other
6397 # Xcode variables depend on it, including variables such as 6384 # Xcode variables depend on it, including variables such as
6398 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6385 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6399 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6386 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6400 # files to appear (when present) in the UI as actual files and not red 6387 # files to appear (when present) in the UI as actual files and not red
6401 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6388 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6402 # and therefore SYMROOT, needs to be set at the project level. 6389 # and therefore SYMROOT, needs to be set at the project level.
6403 'SYMROOT': '<(DEPTH)/xcodebuild', 6390 'SYMROOT': '<(DEPTH)/xcodebuild',
6404 }, 6391 },
6405 } 6392 }
OLDNEW
« no previous file with comments | « base/logging_unittest.cc ('k') | build/config/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698