Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 1869503002: Make existing unit tests only run on GL contexts (Closed)

Created:
4 years, 8 months ago by bsalomon
Modified:
4 years, 8 months ago
Reviewers:
jvanverth1, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -155 lines) Patch
M dm/DM.cpp View 1 chunk +31 lines, -38 lines 0 comments Download
M tests/BitmapCopyTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/BlurTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ClearTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ClipBoundsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/CopySurfaceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/EGLImageTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/FloatingPointTextureTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/GLProgramsTest.cpp View 2 chunks +12 lines, -2 lines 0 comments Download
M tests/GpuColorFilterTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GpuDrawPathTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GpuLayerCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GrDrawTargetTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GrPorterDuffTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GrSurfaceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GrTextureMipMapInvalidationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageFilterCacheTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 12 chunks +12 lines, -12 lines 0 comments Download
M tests/ImageFilterTest.cpp.orig View 12 chunks +12 lines, -12 lines 0 comments Download
M tests/ImageIsOpaqueTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageNewShaderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageTest.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M tests/PremulAlphaRoundTripTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PrimitiveProcessorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ReadPixelsTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/ReadWriteAlphaTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/RecordReplaceDrawTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/RectangleTextureTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ResourceCacheTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/SRGBReadWritePixelsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SpecialImageTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/SpecialSurfaceTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/SurfaceTest.cpp View 15 chunks +15 lines, -15 lines 0 comments Download
M tests/TessellatingPathRendererTests.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/Test.h View 2 chunks +19 lines, -20 lines 0 comments Download
M tests/TestTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/TextBlobCacheTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/TextureStorageAllocator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/WritePixelsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/gpu/GrContextFactory.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
bsalomon
Prep for having a Vulkan context type in GrContextFactory without running all the unit tests ...
4 years, 8 months ago (2016-04-06 17:14:48 UTC) #3
egdaniel
lgtm
4 years, 8 months ago (2016-04-06 20:18:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869503002/20001
4 years, 8 months ago (2016-04-06 20:49:06 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 21:02:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/758586c7f11a6b3529bd4a1c9b4e982a0d0b0582

Powered by Google App Engine
This is Rietveld 408576698