Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 1867293002: [x64] Load int32 constants with movl instead of movq to avoid sign extension. (Closed)

Created:
4 years, 8 months ago by ahaas
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Load int32 constants with movl instead of movq to avoid sign extension. R=bmeurer@chromium.org Committed: https://crrev.com/f7aa8cc70e472fac913ea2e50b27440bf72a789d Cr-Commit-Position: refs/heads/master@{#35352}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M src/compiler/x64/code-generator-x64.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
ahaas
4 years, 8 months ago (2016-04-08 11:21:26 UTC) #1
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-08 11:21:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867293002/1
4 years, 8 months ago (2016-04-08 11:24:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 11:44:54 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 11:46:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7aa8cc70e472fac913ea2e50b27440bf72a789d
Cr-Commit-Position: refs/heads/master@{#35352}

Powered by Google App Engine
This is Rietveld 408576698