chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h - Issue 1869163003: Refactored GlassBrowserFrameView and BrowserDesktopTreeHostWin.

Unified Diff: chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h

Issue 1869163003: Refactored GlassBrowserFrameView and BrowserDesktopTreeHostWin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: edited a comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/frame/glass_browser_frame_view.cc ('K') | « chrome/browser/ui/views/frame/opaque_browser_frame_view.cc ('k') | chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h

diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h b/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h

index e4e9c393cdc8dd32c277457f2099262f4be93d01..1fbb69263f56a0d525f850bfdd60585c239c545f 100644

--- a/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h

+++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h

@@ -76,7 +76,7 @@ class OpaqueBrowserFrameViewLayout : public views::LayoutManager {

// Returns the height of the entire nonclient top border, including the window

// frame, any title area, and any connected client edge. If |restored| is

// true, acts as if the window is restored regardless of the real mode.

Peter Kasting 2016/04/13 01:00:22 Nit: We should probably update the comments on all

Bret 2016/04/13 22:19:47 I need to be careful because some of these comment

- int NonClientTopBorderHeight(bool restored) const;

+ int NonClientTopBorderThickness(bool restored) const;

Peter Kasting 2016/04/13 01:00:22 I'm of two minds regarding this name switch. On o

Bret 2016/04/13 22:19:47 I made a mistake with this one, its equivalent is

int GetTabStripInsetsTop(bool restored) const;