Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc

Issue 1869163003: Refactored GlassBrowserFrameView and BrowserDesktopTreeHostWin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: edited a comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc b/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
index ed796ab96efa4e48c6a67cb79ad05508aaf94a56..937a434a8078b3cf8d43497e4182cdc521d00a5a 100644
--- a/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
+++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
@@ -119,7 +119,7 @@ gfx::Size OpaqueBrowserFrameViewLayout::GetMinimumSize(
gfx::Size min_size = delegate_->GetBrowserViewMinimumSize();
int border_thickness = NonClientBorderThickness();
min_size.Enlarge(2 * border_thickness,
- NonClientTopBorderHeight(false) + border_thickness);
+ NonClientTopBorderThickness(false) + border_thickness);
// Ensure that we can, at minimum, hold our window controls and avatar icon.
min_size.set_width(std::max(min_size.width(), minimum_size_for_buttons_));
@@ -138,7 +138,7 @@ gfx::Size OpaqueBrowserFrameViewLayout::GetMinimumSize(
gfx::Rect OpaqueBrowserFrameViewLayout::GetWindowBoundsForClientBounds(
const gfx::Rect& client_bounds) const {
- int top_height = NonClientTopBorderHeight(false);
+ int top_height = NonClientTopBorderThickness(false);
int border_thickness = NonClientBorderThickness();
return gfx::Rect(std::max(0, client_bounds.x() - border_thickness),
std::max(0, client_bounds.y() - top_height),
@@ -158,7 +158,7 @@ int OpaqueBrowserFrameViewLayout::NonClientBorderThickness() const {
frame : (frame + views::NonClientFrameView::kClientEdgeThickness);
}
-int OpaqueBrowserFrameViewLayout::NonClientTopBorderHeight(
+int OpaqueBrowserFrameViewLayout::NonClientTopBorderThickness(
bool restored) const {
if (delegate_->ShouldShowWindowTitle()) {
// The + 2 here puts at least 1 px of space on top and bottom of the icon.
@@ -180,7 +180,7 @@ int OpaqueBrowserFrameViewLayout::NonClientTopBorderHeight(
}
int OpaqueBrowserFrameViewLayout::GetTabStripInsetsTop(bool restored) const {
- const int top = NonClientTopBorderHeight(restored);
+ const int top = NonClientTopBorderThickness(restored);
// Annoyingly, the pre-MD layout uses different heights for the hit-test
// exclusion region (which we want here, since we're trying to size the border
// so that the region above the tab's hit-test zone matches) versus the shadow
@@ -212,7 +212,7 @@ gfx::Rect OpaqueBrowserFrameViewLayout::IconBounds() const {
gfx::Rect OpaqueBrowserFrameViewLayout::CalculateClientAreaBounds(
int width,
int height) const {
- int top_height = NonClientTopBorderHeight(false);
+ int top_height = NonClientTopBorderThickness(false);
int border_thickness = NonClientBorderThickness();
return gfx::Rect(border_thickness, top_height,
std::max(0, width - (2 * border_thickness)),
@@ -300,7 +300,7 @@ void OpaqueBrowserFrameViewLayout::LayoutTitleBar(views::View* host) {
const int icon_height =
unavailable_px_at_top + size + kContentEdgeShadowThickness;
const int y = unavailable_px_at_top +
- (NonClientTopBorderHeight(false) - icon_height) / 2;
+ (NonClientTopBorderThickness(false) - icon_height) / 2;
window_icon_bounds_ = gfx::Rect(leading_button_start_ + kIconLeftSpacing, y,
size, size);

Powered by Google App Engine
This is Rietveld 408576698