Refactored GlassBrowserFrameView and BrowserDesktopTreeHostWin.

chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_OPAQUE_BROWSER_FRAME_VIEW_LAYOUT_H_
 #define CHROME_BROWSER_UI_VIEWS_FRAME_OPAQUE_BROWSER_FRAME_VIEW_LAYOUT_H_
 
 #include "base/macros.h"
 #include "chrome/browser/ui/views/frame/opaque_browser_frame_view.h"
 #include "ui/views/layout/layout_manager.h"
@@ skipping 57 matching lines @@
   // This does not include any client edge.  If |restored| is true, acts as if
   // the window is restored regardless of the real mode.
   int FrameBorderThickness(bool restored) const;
 
   // Returns the thickness of the entire nonclient left, right, and bottom
   // borders, including both the window frame and any client edge.
   int NonClientBorderThickness() const;
 
   // Returns the height of the entire nonclient top border, including the window
   // frame, any title area, and any connected client edge.  If |restored| is
   // true, acts as if the window is restored regardless of the real mode.

[Peter Kasting, 2016/04/13 01:00:22]

Nit: We should probably update the comments on all matching functions here so
that they're the same as the comments in the glass frame header file.

[Bret, 2016/04/13 22:19:47]

I need to be careful because some of these comments are accurate where they were
not in the glass frame, but I'll update them where it makes sense to.

-  int NonClientTopBorderHeight(bool restored) const;
+  int NonClientTopBorderThickness(bool restored) const;

[Peter Kasting, 2016/04/13 01:00:22]

I'm of two minds regarding this name switch.  On one hand, using "Thickness"
makes it clear this parallels NonClientBorderThickness().  OTOH, we normally use
"width" or "height" in preference to "thickness" when the value refers only to
the horizontal or vertical dimension, because it seems clearer.  So I'm not sure
whether this function's name should change, or the one in the glass frame
should.

[Bret, 2016/04/13 22:19:47]

I made a mistake with this one, its equivalent is actually NonClientTopHeight in
glass. Since opaque doesn't do any trickery with Windows non-client it doesn't
have a separate NonClientTopBorderThickness.

 
   int GetTabStripInsetsTop(bool restored) const;
 
   // Returns the y-coordinate of the caption buttons.  If |restored| is true,
   // acts as if the window is restored regardless of the real mode.
   int CaptionButtonY(bool restored) const;
 
   // Returns the thickness of the 3D edge along the top of the titlebar.  If
   // |restored| is true, acts as if the window is restored regardless of the
   // real mode.
@@ skipping 108 matching lines @@
   AvatarMenuButton* avatar_button_;
   views::View* new_avatar_button_;
 
   std::vector<views::FrameButton> leading_buttons_;
   std::vector<views::FrameButton> trailing_buttons_;
 
   DISALLOW_COPY_AND_ASSIGN(OpaqueBrowserFrameViewLayout);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_FRAME_OPAQUE_BROWSER_FRAME_VIEW_LAYOUT_H_