chrome/browser/android/ntp/ntp_snippets_bridge.h - Issue 1869023002: [NTP Snippets] SnippetsBridge: register as SnippetsObserver only when we get a Java observer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/ntp/ntp_snippets_bridge.h

Issue 1869023002: [NTP Snippets] SnippetsBridge: register as SnippetsObserver only when we get a Java observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@snippets_service_cleanup

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/ntp/ntp_snippets_bridge.h

diff --git a/chrome/browser/android/ntp/ntp_snippets_bridge.h b/chrome/browser/android/ntp/ntp_snippets_bridge.h

index 8fb932adc6d52920f95d0f75906994baffab04f8..0011c99c1254da0398748403cd62618e07628037 100644

--- a/chrome/browser/android/ntp/ntp_snippets_bridge.h

+++ b/chrome/browser/android/ntp/ntp_snippets_bridge.h

@@ -34,10 +34,8 @@ class NTPSnippetsBridge : public ntp_snippets::NTPSnippetsServiceObserver {

~NTPSnippetsBridge() override;

// NTPSnippetsServiceObserver overrides

- void NTPSnippetsServiceLoaded(

- ntp_snippets::NTPSnippetsService* service) override;

- void NTPSnippetsServiceShutdown(

- ntp_snippets::NTPSnippetsService* service) override;

+ void NTPSnippetsServiceLoaded() override;

+ void NTPSnippetsServiceShutdown() override;

ntp_snippets::NTPSnippetsService* ntp_snippets_service_;

« no previous file with comments | « no previous file | chrome/browser/android/ntp/ntp_snippets_bridge.cc » ('j') | no next file with comments »