Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: chrome/browser/extensions/api/cookies/cookies_helpers.cc

Issue 1868493002: Ignore cookies with invalid 'SameSite' attribute values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/cookies/cookies_helpers.cc
diff --git a/chrome/browser/extensions/api/cookies/cookies_helpers.cc b/chrome/browser/extensions/api/cookies/cookies_helpers.cc
index 350a5b94a1dd2ee08bf9400125ef1a0a064f4b7f..c18669ee4b061072be13187c8d0ef1b833dedc79 100644
--- a/chrome/browser/extensions/api/cookies/cookies_helpers.cc
+++ b/chrome/browser/extensions/api/cookies/cookies_helpers.cc
@@ -91,6 +91,10 @@ Cookie CreateCookie(const net::CanonicalCookie& canonical_cookie,
case net::CookieSameSite::STRICT_MODE:
cookie.same_site = api::cookies::SAME_SITE_STATUS_STRICT;
break;
+ case net::CookieSameSite::INVALID_MODE:
mmenke 2016/04/06 15:16:30 It seems unfortunate that we need to expose this n
+ NOTREACHED();
+ cookie.same_site = api::cookies::SAME_SITE_STATUS_STRICT;
+ break;
}
cookie.session = !canonical_cookie.IsPersistent();
« no previous file with comments | « no previous file | content/browser/devtools/protocol/network_handler.cc » ('j') | net/cookies/cookie_constants.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698