Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: content/browser/devtools/protocol/network_handler.cc

Issue 1868493002: Ignore cookies with invalid 'SameSite' attribute values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/network_handler.cc
diff --git a/content/browser/devtools/protocol/network_handler.cc b/content/browser/devtools/protocol/network_handler.cc
index 5163f19b853af7839a0038a5ba9404970d2b2a85..ed2cdcc2ed52a3181d5a51e7656cd39add18219f 100644
--- a/content/browser/devtools/protocol/network_handler.cc
+++ b/content/browser/devtools/protocol/network_handler.cc
@@ -254,6 +254,10 @@ void NetworkHandler::SendGetCookiesResponse(
break;
case net::CookieSameSite::NO_RESTRICTION:
break;
+ case net::CookieSameSite::INVALID_MODE:
+ NOTREACHED();
+ devtools_cookie->set_same_site(cookie::kSameSiteStrict);
+ break;
}
cookies.push_back(devtools_cookie);
}

Powered by Google App Engine
This is Rietveld 408576698