Ignore cookies with invalid 'SameSite' attribute values.

chrome/browser/extensions/api/cookies/cookies_helpers.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implements common functionality for the Chrome Extensions Cookies API.
 
 #include "chrome/browser/extensions/api/cookies/cookies_helpers.h"
 
 #include <stddef.h>
 
@@ skipping 73 matching lines @@
   switch (canonical_cookie.SameSite()) {
   case net::CookieSameSite::DEFAULT_MODE:
     cookie.same_site = api::cookies::SAME_SITE_STATUS_NO_RESTRICTION;
     break;
   case net::CookieSameSite::LAX_MODE:
     cookie.same_site = api::cookies::SAME_SITE_STATUS_LAX;
     break;
   case net::CookieSameSite::STRICT_MODE:
     cookie.same_site = api::cookies::SAME_SITE_STATUS_STRICT;
     break;
+  case net::CookieSameSite::INVALID_MODE:

[mmenke, 2016/04/06 15:16:30]

It seems unfortunate that we need to expose this new invalid SameSite state as
part of the API.  I don't suppose we could simple reflect this error as part of
the ParsedCookie.IsValid, and not add a value in the enum?

+    NOTREACHED();
+    cookie.same_site = api::cookies::SAME_SITE_STATUS_STRICT;
+    break;
   }
 
   cookie.session = !canonical_cookie.IsPersistent();
   if (canonical_cookie.IsPersistent()) {
     cookie.expiration_date.reset(
         new double(canonical_cookie.ExpiryDate().ToDoubleT()));
   }
   cookie.store_id = store_id;
 
   return cookie;
@@ skipping 106 matching lines @@
     if (sub_domain == *details_->domain)
       return true;
     const size_t next_dot = sub_domain.find('.', 1);  // Skip over leading dot.
     sub_domain.erase(0, next_dot);
   }
   return false;
 }
 
 }  // namespace cookies_helpers
 }  // namespace extensions