Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 1868433002: Rename function names to match the DOM Standard (Closed)

Created:
4 years, 8 months ago by hayato
Modified:
4 years, 8 months ago
Reviewers:
tkent, haraken, kochi
CC:
aboxhall, aboxhall+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dcheng, dglazkov+blink, dmazzoni, dmazzoni+watch_chromium.org, dtapuska+blinkwatch_chromium.org, dtseng+watch_chromium.org, eae+blinkwatch, je_julie, nektarios, nektar+watch_chromium.org, rwlbuis, sof, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename function names to match the DOM Standard containsIncludingShadowDOM -> isShadowIncludingInclusiveAncestorOf rootInComposedTree -> shadowIncludingRoot BUG=531990 Committed: https://crrev.com/a1c03227f44063cd2b42a79fa17ffbcd673191fe Cr-Commit-Position: refs/heads/master@{#385643}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -30 lines) Patch
M third_party/WebKit/Source/core/dom/ChildFrameDisconnector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 2 chunks +2 lines, -1 line 1 comment Download
M third_party/WebKit/Source/core/dom/Node.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeChildRemovalTracker.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Range.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/DragCaretController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLabelElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/page/DragController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868433002/1
4 years, 8 months ago (2016-04-06 08:44:49 UTC) #2
hayato
PTAL
4 years, 8 months ago (2016-04-06 08:47:24 UTC) #6
kochi
lgtm https://codereview.chromium.org/1868433002/diff/1/third_party/WebKit/Source/core/dom/Node.h File third_party/WebKit/Source/core/dom/Node.h (right): https://codereview.chromium.org/1868433002/diff/1/third_party/WebKit/Source/core/dom/Node.h#newcode217 third_party/WebKit/Source/core/dom/Node.h:217: Node& shadowIncludingRoot() const; Do you use this in ...
4 years, 8 months ago (2016-04-06 08:56:29 UTC) #7
hayato
On 2016/04/06 at 08:56:29, kochi wrote: > lgtm > > https://codereview.chromium.org/1868433002/diff/1/third_party/WebKit/Source/core/dom/Node.h > File third_party/WebKit/Source/core/dom/Node.h (right): ...
4 years, 8 months ago (2016-04-06 09:05:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868433002/1
4 years, 8 months ago (2016-04-06 09:05:46 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/165117)
4 years, 8 months ago (2016-04-06 09:16:25 UTC) #13
haraken
modules/ LGTM
4 years, 8 months ago (2016-04-06 09:17:42 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868433002/1
4 years, 8 months ago (2016-04-07 03:18:31 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 03:23:55 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 03:24:54 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1c03227f44063cd2b42a79fa17ffbcd673191fe
Cr-Commit-Position: refs/heads/master@{#385643}

Powered by Google App Engine
This is Rietveld 408576698