third_party/WebKit/Source/core/dom/Range.cpp - Issue 1868433002: Rename function names to match the DOM Standard

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Range.cpp

Issue 1868433002: Rename function names to match the DOM Standard (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Range.cpp

diff --git a/third_party/WebKit/Source/core/dom/Range.cpp b/third_party/WebKit/Source/core/dom/Range.cpp

index 60ddc576072db4e9b545b0c43124ad326f4d6bb1..ffc338f5f9ef5b2d38a854c1e21edf754e102a79 100644

--- a/third_party/WebKit/Source/core/dom/Range.cpp

+++ b/third_party/WebKit/Source/core/dom/Range.cpp

@@ -1218,7 +1218,7 @@ void Range::surroundContents(RawPtr<Node> passNewParent, ExceptionState& excepti

return;

}

- if (newParent->containsIncludingShadowDOM(m_start.container())) {

+ if (newParent->isShadowIncludingInclusiveAncestorOf(m_start.container())) {

exceptionState.throwDOMException(HierarchyRequestError, "The node provided contains the insertion point; it may not be inserted into itself.");

return;

}