Add use counters for function values of easing

Add use counters for function values of easing

Due to a bug in old versions of the web-animations-next polyfill, in
some circumstances the string passed in to
AnimationInputHelpers::parseTimingFunction may be a Javascript
function instead of the allowed values from the spec
(http://w3c.github.io/web-animations/#dom-animationeffecttimingreadonly-easing)
This bug was fixed in
https://github.com/web-animations/web-animations-next/pull/423
and we want to track how often it is still being hit. The linear case
is special because 'linear' is the default value for easing.

BUG=601672
Committed: https://crrev.com/51a95e49695ae972bc8315dca6b4a3c08a486910
Cr-Commit-Position: refs/heads/master@{#386037}

[suzyh_UTC10 (ex-contributor), 2016-04-07 07:05:47]

suzyh@chromium.org changed reviewers:
+ dstockwell@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-04-07 07:06:41]

The only thing that's missing now is a layout test for the use-counting itself;
I'll get on to that first thing tomorrow.

[suzyh_UTC10 (ex-contributor), 2016-04-07 07:06:46]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 07:07:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867803002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867803002/1

[alancutter (OOO until 2018), 2016-04-07 07:36:19]

alancutter@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2016-04-07 07:36:20]

https://codereview.chromium.org/1867803002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/AnimationEffectTiming.cpp (right):

https://codereview.chromium.org/1867803002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/AnimationEffectTiming.cpp:133:
TimingInput::setTimingFunction(timing, easing, nullptr);
I would add a TODO here to add [SetterCallWith=Document] to IDL or a comment
explaining why it's okay to not use count this scenario.

https://codereview.chromium.org/1867803002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp (right):

https://codereview.chromium.org/1867803002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp:225: if
(string == "function(a) {return a}")
According to
https://luci-logdog.appspot.com/v/?s=bb%2Ftryserver.chromium.linux%2Flinux_ch...
the string is actually "function (a){return a}".

https://codereview.chromium.org/1867803002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/TimingInputTest.cpp (right):

https://codereview.chromium.org/1867803002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/TimingInputTest.cpp:11: #include
"core/testing/DummyPageHolder.h"
No need to add this if use counting isn't being tested here and nullptr is an
acceptable value.

[commit-bot: I haz the power, 2016-04-07 08:26:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 08:26:27]

Dry run: This issue passed the CQ dry run.

[suzyh_UTC10 (ex-contributor), 2016-04-08 01:14:23]

I've now added tests for the use counters. I've had to split it up into three
test files because that seems to be the only way to clear the use counter for
each test.


On 2016/04/07 at 07:36:20, alancutter wrote:
>
https://codereview.chromium.org/1867803002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/animation/AnimationEffectTiming.cpp
(right):
> 
>
https://codereview.chromium.org/1867803002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/animation/AnimationEffectTiming.cpp:133:
TimingInput::setTimingFunction(timing, easing, nullptr);
> I would add a TODO here to add [SetterCallWith=Document] to IDL or a comment
explaining why it's okay to not use count this scenario.

Done.


>
https://codereview.chromium.org/1867803002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp
(right):
> 
>
https://codereview.chromium.org/1867803002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp:225: if
(string == "function(a) {return a}")
> According to
https://luci-logdog.appspot.com/v/?s=bb%2Ftryserver.chromium.linux%2Flinux_ch...
the string is actually "function (a){return a}".

Whoops, I thought I'd copy-pasted it, but evidently not. Good catch.


>
https://codereview.chromium.org/1867803002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/animation/TimingInputTest.cpp (right):
> 
>
https://codereview.chromium.org/1867803002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/animation/TimingInputTest.cpp:11: #include
"core/testing/DummyPageHolder.h"
> No need to add this if use counting isn't being tested here and nullptr is an
acceptable value.

Done.

[suzyh_UTC10 (ex-contributor), 2016-04-08 01:14:28]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-08 01:14:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867803002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867803002/20001

[commit-bot: I haz the power, 2016-04-08 01:18:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 01:18:16]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Timothy Loh, 2016-04-08 01:20:25]

Is there a tracking bug or something like that? It isn't clear to me why we want
to count this or what we're going to do with the data.

[suzyh_UTC10 (ex-contributor), 2016-04-08 01:26:17]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-08 01:26:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867803002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867803002/40001

[suzyh_UTC10 (ex-contributor), 2016-04-08 01:43:37]

Description was changed from

==========
Add use counters for function values of easing

Due to a bug in old versions of the web-animations-next polyfill, in
some circumstances the string passed in here may be a Javascript
function instead of the allowed values from the spec
(http://w3c.github.io/web-animations/#dom-animationeffecttimingreadonly-easing)
This bug was fixed in
https://github.com/web-animations/web-animations-next/pull/423
and we want to track how often it is still being hit. The linear case
is special because 'linear' is the default value for easing.

BUG=
==========

to

==========
Add use counters for function values of easing

Due to a bug in old versions of the web-animations-next polyfill, in
some circumstances the string passed in here may be a Javascript
function instead of the allowed values from the spec
(http://w3c.github.io/web-animations/#dom-animationeffecttimingreadonly-easing)
This bug was fixed in
https://github.com/web-animations/web-animations-next/pull/423
and we want to track how often it is still being hit. The linear case
is special because 'linear' is the default value for easing.

BUG=601672
==========

[suzyh_UTC10 (ex-contributor), 2016-04-08 01:43:48]

On 2016/04/08 at 01:20:25, timloh wrote:
> Is there a tracking bug or something like that? It isn't clear to me why we
want to count this or what we're going to do with the data.

Done: crbug.com/601672

[suzyh_UTC10 (ex-contributor), 2016-04-08 01:46:20]

Description was changed from

==========
Add use counters for function values of easing

Due to a bug in old versions of the web-animations-next polyfill, in
some circumstances the string passed in here may be a Javascript
function instead of the allowed values from the spec
(http://w3c.github.io/web-animations/#dom-animationeffecttimingreadonly-easing)
This bug was fixed in
https://github.com/web-animations/web-animations-next/pull/423
and we want to track how often it is still being hit. The linear case
is special because 'linear' is the default value for easing.

BUG=601672
==========

to

==========
Add use counters for function values of easing

Due to a bug in old versions of the web-animations-next polyfill, in
some circumstances the string passed in to
AnimationInputHelpers::parseTimingFunction may be a Javascript
function instead of the allowed values from the spec
(http://w3c.github.io/web-animations/#dom-animationeffecttimingreadonly-easing)
This bug was fixed in
https://github.com/web-animations/web-animations-next/pull/423
and we want to track how often it is still being hit. The linear case
is special because 'linear' is the default value for easing.

BUG=601672
==========

[alancutter (OOO until 2018), 2016-04-08 02:05:18]

lgtm

[dstockwell, 2016-04-08 02:44:08]

lgtm

[suzyh_UTC10 (ex-contributor), 2016-04-08 02:53:31]

suzyh@chromium.org changed reviewers:
+ isherman@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-04-08 02:53:51]

+isherman for tools/metrics OWNERS approval

[suzyh_UTC10 (ex-contributor), 2016-04-08 03:08:46]

On 2016/04/08 at 02:53:51, suzyh wrote:
> +isherman for tools/metrics OWNERS approval

By the way, the tools/metrics approval is the last blocker here, so feel free to
send this to the commit queue if you're happy with it.

[commit-bot: I haz the power, 2016-04-08 03:12:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 03:12:21]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2016-04-08 05:59:31]

histograms.xml lgtm

[Ilya Sherman, 2016-04-08 05:59:37]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2016-04-08 05:59:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867803002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867803002/40001

[commit-bot: I haz the power, 2016-04-08 06:06:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 06:06:51]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[suzyh_UTC10 (ex-contributor), 2016-04-08 06:25:12]

The CQ bit was checked by suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-04-08 06:25:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
dstockwell@chromium.org, isherman@chromium.org, alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/1867803002/#ps60001
(title: "Rebase, updating UseCounter enum values")

[commit-bot: I haz the power, 2016-04-08 06:25:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867803002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867803002/60001

[commit-bot: I haz the power, 2016-04-08 07:51:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 07:51:25]

Failed to apply patch for third_party/WebKit/Source/core/frame/UseCounter.h:
While running git apply --index -3 -p1;
  error: patch failed: third_party/WebKit/Source/core/frame/UseCounter.h:1106
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/Source/core/frame/UseCounter.h' with
conflicts.
  U third_party/WebKit/Source/core/frame/UseCounter.h

Patch:       third_party/WebKit/Source/core/frame/UseCounter.h
Index: third_party/WebKit/Source/core/frame/UseCounter.h
diff --git a/third_party/WebKit/Source/core/frame/UseCounter.h
b/third_party/WebKit/Source/core/frame/UseCounter.h
index
1135f8ddc9388e1a4ed20243378251945bdf4074..b8de1868a8a18af387647d469a34f3ceb1a439a8
100644
--- a/third_party/WebKit/Source/core/frame/UseCounter.h
+++ b/third_party/WebKit/Source/core/frame/UseCounter.h
@@ -1106,6 +1106,8 @@ public:
         SVGCalcModeLinear = 1288,
         SVGCalcModePaced = 1289,
         SVGCalcModeSpline = 1290,
+        WebAnimationsEasingAsFunctionLinear = 1291,
+        WebAnimationsEasingAsFunctionOther = 1292,
 
         // Add new features immediately above this line. Don't change assigned
         // numbers of any item, and don't reuse removed slots.

[suzyh_UTC10 (ex-contributor), 2016-04-08 07:53:27]

The CQ bit was checked by suzyh@chromium.org

[commit-bot: I haz the power, 2016-04-08 07:53:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867803002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867803002/60001

[commit-bot: I haz the power, 2016-04-08 08:00:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 08:00:03]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[suzyh_UTC10 (ex-contributor), 2016-04-08 08:07:56]

The CQ bit was checked by suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-04-08 08:07:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
dstockwell@chromium.org, isherman@chromium.org, alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/1867803002/#ps80001
(title: "Rebase and update UseCounters again")

[commit-bot: I haz the power, 2016-04-08 08:08:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867803002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867803002/80001

[commit-bot: I haz the power, 2016-04-08 10:21:59]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-08 10:23:16]

Description was changed from

==========
Add use counters for function values of easing

Due to a bug in old versions of the web-animations-next polyfill, in
some circumstances the string passed in to
AnimationInputHelpers::parseTimingFunction may be a Javascript
function instead of the allowed values from the spec
(http://w3c.github.io/web-animations/#dom-animationeffecttimingreadonly-easing)
This bug was fixed in
https://github.com/web-animations/web-animations-next/pull/423
and we want to track how often it is still being hit. The linear case
is special because 'linear' is the default value for easing.

BUG=601672
==========

to

==========
Add use counters for function values of easing

Due to a bug in old versions of the web-animations-next polyfill, in
some circumstances the string passed in to
AnimationInputHelpers::parseTimingFunction may be a Javascript
function instead of the allowed values from the spec
(http://w3c.github.io/web-animations/#dom-animationeffecttimingreadonly-easing)
This bug was fixed in
https://github.com/web-animations/web-animations-next/pull/423
and we want to track how often it is still being hit. The linear case
is special because 'linear' is the default value for easing.

BUG=601672

Committed: https://crrev.com/51a95e49695ae972bc8315dca6b4a3c08a486910
Cr-Commit-Position: refs/heads/master@{#386037}
==========

[commit-bot: I haz the power, 2016-04-08 10:23:18]

Patchset 5 (id:??) landed as
https://crrev.com/51a95e49695ae972bc8315dca6b4a3c08a486910
Cr-Commit-Position: refs/heads/master@{#386037}