Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: third_party/WebKit/Source/core/animation/TimingInputTest.cpp

Issue 1867803002: Add use counters for function values of easing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/animation/TimingInput.h" 5 #include "core/animation/TimingInput.h"
6 6
7 #include "bindings/core/v8/V8BindingForTesting.h" 7 #include "bindings/core/v8/V8BindingForTesting.h"
8 #include "bindings/core/v8/V8KeyframeEffectOptions.h" 8 #include "bindings/core/v8/V8KeyframeEffectOptions.h"
9 #include "core/animation/AnimationEffectTiming.h" 9 #include "core/animation/AnimationEffectTiming.h"
10 #include "core/animation/AnimationTestHelper.h" 10 #include "core/animation/AnimationTestHelper.h"
11 #include "core/testing/DummyPageHolder.h"
alancutter (OOO until 2018) 2016/04/07 07:36:20 No need to add this if use counting isn't being te
11 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
12 #include <v8.h> 13 #include <v8.h>
13 14
14 namespace blink { 15 namespace blink {
15 16
16 class AnimationTimingInputTest : public ::testing::Test { 17 class AnimationTimingInputTest : public ::testing::Test {
17 protected: 18 protected:
18 AnimationTimingInputTest() 19 AnimationTimingInputTest()
19 : m_isolate(v8::Isolate::GetCurrent()) 20 : m_isolate(v8::Isolate::GetCurrent())
20 , m_scope(m_isolate) 21 , m_scope(m_isolate)
21 { 22 {
22 } 23 }
23 24
25 void SetUp() override
26 {
27 pageHolder = DummyPageHolder::create();
28 document = &pageHolder->document();
29 }
30
31 void TearDown() override
32 {
33 document.release();
34 #if ENABLE(OILPAN)
35 Heap::collectAllGarbage();
36 #endif
37 }
38
24 Timing applyTimingInputNumber(String timingProperty, double timingPropertyVa lue) 39 Timing applyTimingInputNumber(String timingProperty, double timingPropertyVa lue)
25 { 40 {
26 v8::Local<v8::Object> timingInput = v8::Object::New(m_isolate); 41 v8::Local<v8::Object> timingInput = v8::Object::New(m_isolate);
27 setV8ObjectPropertyAsNumber(m_isolate, timingInput, timingProperty, timi ngPropertyValue); 42 setV8ObjectPropertyAsNumber(m_isolate, timingInput, timingProperty, timi ngPropertyValue);
28 KeyframeEffectOptions timingInputDictionary; 43 KeyframeEffectOptions timingInputDictionary;
29 V8KeyframeEffectOptions::toImpl(m_isolate, timingInput, timingInputDicti onary, exceptionState); 44 V8KeyframeEffectOptions::toImpl(m_isolate, timingInput, timingInputDicti onary, exceptionState);
30 return TimingInput::convert(timingInputDictionary); 45 return TimingInput::convert(timingInputDictionary, document);
31 } 46 }
32 47
33 Timing applyTimingInputString(String timingProperty, String timingPropertyVa lue) 48 Timing applyTimingInputString(String timingProperty, String timingPropertyVa lue)
34 { 49 {
35 v8::Local<v8::Object> timingInput = v8::Object::New(m_isolate); 50 v8::Local<v8::Object> timingInput = v8::Object::New(m_isolate);
36 setV8ObjectPropertyAsString(m_isolate, timingInput, timingProperty, timi ngPropertyValue); 51 setV8ObjectPropertyAsString(m_isolate, timingInput, timingProperty, timi ngPropertyValue);
37 KeyframeEffectOptions timingInputDictionary; 52 KeyframeEffectOptions timingInputDictionary;
38 V8KeyframeEffectOptions::toImpl(m_isolate, timingInput, timingInputDicti onary, exceptionState); 53 V8KeyframeEffectOptions::toImpl(m_isolate, timingInput, timingInputDicti onary, exceptionState);
39 return TimingInput::convert(timingInputDictionary); 54 return TimingInput::convert(timingInputDictionary, document);
55 }
56
57 Timing convert(const KeyframeEffectOptions& timingInput)
58 {
59 return TimingInput::convert(timingInput, document);
40 } 60 }
41 61
42 v8::Isolate* m_isolate; 62 v8::Isolate* m_isolate;
43 TrackExceptionState exceptionState; 63 TrackExceptionState exceptionState;
64 OwnPtr<DummyPageHolder> pageHolder;
65 Persistent<Document> document;
44 66
45 private: 67 private:
46 V8TestingScope m_scope; 68 V8TestingScope m_scope;
47 }; 69 };
48 70
49 TEST_F(AnimationTimingInputTest, TimingInputStartDelay) 71 TEST_F(AnimationTimingInputTest, TimingInputStartDelay)
50 { 72 {
51 EXPECT_EQ(1.1, applyTimingInputNumber("delay", 1100).startDelay); 73 EXPECT_EQ(1.1, applyTimingInputNumber("delay", 1100).startDelay);
52 EXPECT_EQ(-1, applyTimingInputNumber("delay", -1000).startDelay); 74 EXPECT_EQ(-1, applyTimingInputNumber("delay", -1000).startDelay);
53 EXPECT_EQ(1, applyTimingInputString("delay", "1000").startDelay); 75 EXPECT_EQ(1, applyTimingInputString("delay", "1000").startDelay);
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 EXPECT_EQ(*defaultTimingFunction, *applyTimingInputString("easing", "steps(5 .6, end)").timingFunction); 181 EXPECT_EQ(*defaultTimingFunction, *applyTimingInputString("easing", "steps(5 .6, end)").timingFunction);
160 EXPECT_EQ(*defaultTimingFunction, *applyTimingInputString("easing", "cubic-b ezier(2, 2, 0.3, 0.3)").timingFunction); 182 EXPECT_EQ(*defaultTimingFunction, *applyTimingInputString("easing", "cubic-b ezier(2, 2, 0.3, 0.3)").timingFunction);
161 EXPECT_EQ(*defaultTimingFunction, *applyTimingInputString("easing", "rubbish ").timingFunction); 183 EXPECT_EQ(*defaultTimingFunction, *applyTimingInputString("easing", "rubbish ").timingFunction);
162 EXPECT_EQ(*defaultTimingFunction, *applyTimingInputNumber("easing", 2).timin gFunction); 184 EXPECT_EQ(*defaultTimingFunction, *applyTimingInputNumber("easing", 2).timin gFunction);
163 EXPECT_EQ(*defaultTimingFunction, *applyTimingInputString("easing", "initial ").timingFunction); 185 EXPECT_EQ(*defaultTimingFunction, *applyTimingInputString("easing", "initial ").timingFunction);
164 } 186 }
165 187
166 TEST_F(AnimationTimingInputTest, TimingInputEmpty) 188 TEST_F(AnimationTimingInputTest, TimingInputEmpty)
167 { 189 {
168 Timing controlTiming; 190 Timing controlTiming;
169 Timing updatedTiming = TimingInput::convert(KeyframeEffectOptions()); 191 Timing updatedTiming = convert(KeyframeEffectOptions());
170 192
171 EXPECT_EQ(controlTiming.startDelay, updatedTiming.startDelay); 193 EXPECT_EQ(controlTiming.startDelay, updatedTiming.startDelay);
172 EXPECT_EQ(controlTiming.fillMode, updatedTiming.fillMode); 194 EXPECT_EQ(controlTiming.fillMode, updatedTiming.fillMode);
173 EXPECT_EQ(controlTiming.iterationStart, updatedTiming.iterationStart); 195 EXPECT_EQ(controlTiming.iterationStart, updatedTiming.iterationStart);
174 EXPECT_EQ(controlTiming.iterationCount, updatedTiming.iterationCount); 196 EXPECT_EQ(controlTiming.iterationCount, updatedTiming.iterationCount);
175 EXPECT_TRUE(std::isnan(updatedTiming.iterationDuration)); 197 EXPECT_TRUE(std::isnan(updatedTiming.iterationDuration));
176 EXPECT_EQ(controlTiming.playbackRate, updatedTiming.playbackRate); 198 EXPECT_EQ(controlTiming.playbackRate, updatedTiming.playbackRate);
177 EXPECT_EQ(controlTiming.direction, updatedTiming.direction); 199 EXPECT_EQ(controlTiming.direction, updatedTiming.direction);
178 EXPECT_EQ(*controlTiming.timingFunction, *updatedTiming.timingFunction); 200 EXPECT_EQ(*controlTiming.timingFunction, *updatedTiming.timingFunction);
179 } 201 }
180 202
181 } // namespace blink 203 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698