Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: third_party/WebKit/Source/core/animation/TimingInputTest.cpp

Issue 1867803002: Add use counters for function values of easing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and update UseCounters again Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/animation/TimingInput.h" 5 #include "core/animation/TimingInput.h"
6 6
7 #include "bindings/core/v8/V8BindingForTesting.h" 7 #include "bindings/core/v8/V8BindingForTesting.h"
8 #include "bindings/core/v8/V8KeyframeEffectOptions.h" 8 #include "bindings/core/v8/V8KeyframeEffectOptions.h"
9 #include "core/animation/AnimationEffectTiming.h" 9 #include "core/animation/AnimationEffectTiming.h"
10 #include "core/animation/AnimationTestHelper.h" 10 #include "core/animation/AnimationTestHelper.h"
11 #include "core/testing/DummyPageHolder.h"
11 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
12 #include <v8.h> 13 #include <v8.h>
13 14
14 namespace blink { 15 namespace blink {
15 16
16 class AnimationTimingInputTest : public ::testing::Test { 17 class AnimationTimingInputTest : public ::testing::Test {
17 protected: 18 protected:
18 AnimationTimingInputTest() 19 AnimationTimingInputTest()
19 : m_isolate(v8::Isolate::GetCurrent()) 20 : m_isolate(v8::Isolate::GetCurrent())
20 , m_scope(m_isolate) 21 , m_scope(m_isolate)
21 { 22 {
22 } 23 }
23 24
24 Timing applyTimingInputNumber(String timingProperty, double timingPropertyVa lue) 25 Timing applyTimingInputNumber(String timingProperty, double timingPropertyVa lue)
25 { 26 {
26 v8::Local<v8::Object> timingInput = v8::Object::New(m_isolate); 27 v8::Local<v8::Object> timingInput = v8::Object::New(m_isolate);
27 setV8ObjectPropertyAsNumber(m_isolate, timingInput, timingProperty, timi ngPropertyValue); 28 setV8ObjectPropertyAsNumber(m_isolate, timingInput, timingProperty, timi ngPropertyValue);
28 KeyframeEffectOptions timingInputDictionary; 29 KeyframeEffectOptions timingInputDictionary;
29 V8KeyframeEffectOptions::toImpl(m_isolate, timingInput, timingInputDicti onary, exceptionState); 30 V8KeyframeEffectOptions::toImpl(m_isolate, timingInput, timingInputDicti onary, exceptionState);
30 return TimingInput::convert(timingInputDictionary); 31 return TimingInput::convert(timingInputDictionary, nullptr);
31 } 32 }
32 33
33 Timing applyTimingInputString(String timingProperty, String timingPropertyVa lue) 34 Timing applyTimingInputString(String timingProperty, String timingPropertyVa lue)
34 { 35 {
35 v8::Local<v8::Object> timingInput = v8::Object::New(m_isolate); 36 v8::Local<v8::Object> timingInput = v8::Object::New(m_isolate);
36 setV8ObjectPropertyAsString(m_isolate, timingInput, timingProperty, timi ngPropertyValue); 37 setV8ObjectPropertyAsString(m_isolate, timingInput, timingProperty, timi ngPropertyValue);
37 KeyframeEffectOptions timingInputDictionary; 38 KeyframeEffectOptions timingInputDictionary;
38 V8KeyframeEffectOptions::toImpl(m_isolate, timingInput, timingInputDicti onary, exceptionState); 39 V8KeyframeEffectOptions::toImpl(m_isolate, timingInput, timingInputDicti onary, exceptionState);
39 return TimingInput::convert(timingInputDictionary); 40 return TimingInput::convert(timingInputDictionary, nullptr);
40 } 41 }
41 42
42 v8::Isolate* m_isolate; 43 v8::Isolate* m_isolate;
43 TrackExceptionState exceptionState; 44 TrackExceptionState exceptionState;
44 45
45 private: 46 private:
46 V8TestingScope m_scope; 47 V8TestingScope m_scope;
47 }; 48 };
48 49
49 TEST_F(AnimationTimingInputTest, TimingInputStartDelay) 50 TEST_F(AnimationTimingInputTest, TimingInputStartDelay)
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 EXPECT_EQ(*defaultTimingFunction, *applyTimingInputString("easing", "steps(5 .6, end)").timingFunction); 160 EXPECT_EQ(*defaultTimingFunction, *applyTimingInputString("easing", "steps(5 .6, end)").timingFunction);
160 EXPECT_EQ(*defaultTimingFunction, *applyTimingInputString("easing", "cubic-b ezier(2, 2, 0.3, 0.3)").timingFunction); 161 EXPECT_EQ(*defaultTimingFunction, *applyTimingInputString("easing", "cubic-b ezier(2, 2, 0.3, 0.3)").timingFunction);
161 EXPECT_EQ(*defaultTimingFunction, *applyTimingInputString("easing", "rubbish ").timingFunction); 162 EXPECT_EQ(*defaultTimingFunction, *applyTimingInputString("easing", "rubbish ").timingFunction);
162 EXPECT_EQ(*defaultTimingFunction, *applyTimingInputNumber("easing", 2).timin gFunction); 163 EXPECT_EQ(*defaultTimingFunction, *applyTimingInputNumber("easing", 2).timin gFunction);
163 EXPECT_EQ(*defaultTimingFunction, *applyTimingInputString("easing", "initial ").timingFunction); 164 EXPECT_EQ(*defaultTimingFunction, *applyTimingInputString("easing", "initial ").timingFunction);
164 } 165 }
165 166
166 TEST_F(AnimationTimingInputTest, TimingInputEmpty) 167 TEST_F(AnimationTimingInputTest, TimingInputEmpty)
167 { 168 {
168 Timing controlTiming; 169 Timing controlTiming;
169 Timing updatedTiming = TimingInput::convert(KeyframeEffectOptions()); 170 Timing updatedTiming = TimingInput::convert(KeyframeEffectOptions(), nullptr );
170 171
171 EXPECT_EQ(controlTiming.startDelay, updatedTiming.startDelay); 172 EXPECT_EQ(controlTiming.startDelay, updatedTiming.startDelay);
172 EXPECT_EQ(controlTiming.fillMode, updatedTiming.fillMode); 173 EXPECT_EQ(controlTiming.fillMode, updatedTiming.fillMode);
173 EXPECT_EQ(controlTiming.iterationStart, updatedTiming.iterationStart); 174 EXPECT_EQ(controlTiming.iterationStart, updatedTiming.iterationStart);
174 EXPECT_EQ(controlTiming.iterationCount, updatedTiming.iterationCount); 175 EXPECT_EQ(controlTiming.iterationCount, updatedTiming.iterationCount);
175 EXPECT_TRUE(std::isnan(updatedTiming.iterationDuration)); 176 EXPECT_TRUE(std::isnan(updatedTiming.iterationDuration));
176 EXPECT_EQ(controlTiming.playbackRate, updatedTiming.playbackRate); 177 EXPECT_EQ(controlTiming.playbackRate, updatedTiming.playbackRate);
177 EXPECT_EQ(controlTiming.direction, updatedTiming.direction); 178 EXPECT_EQ(controlTiming.direction, updatedTiming.direction);
178 EXPECT_EQ(*controlTiming.timingFunction, *updatedTiming.timingFunction); 179 EXPECT_EQ(*controlTiming.timingFunction, *updatedTiming.timingFunction);
179 } 180 }
180 181
181 } // namespace blink 182 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/animation/TimingInput.cpp ('k') | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698