Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5467)

Unified Diff: chrome/test/chromedriver/chrome/web_view_impl.cc

Issue 1867523002: Rename ignore_cache and ignoreCache to bypass* unless it affects API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/web_view_impl.cc
diff --git a/chrome/test/chromedriver/chrome/web_view_impl.cc b/chrome/test/chromedriver/chrome/web_view_impl.cc
index 23b13a61c15b17d7015dca77e604b88a39ff154d..2d5d1e0aa59dde76f2e5dd7089928628285bd3c8 100644
--- a/chrome/test/chromedriver/chrome/web_view_impl.cc
+++ b/chrome/test/chromedriver/chrome/web_view_impl.cc
@@ -191,6 +191,8 @@ Status WebViewImpl::Load(const std::string& url) {
Status WebViewImpl::Reload() {
base::DictionaryValue params;
+ // TODO(toyoshim): Check if this ignoreCache shouldn't be changed for
dgozman 2016/04/06 15:44:19 This is a public API usage as well.
Takashi Toyoshima 2016/04/08 04:50:54 Acknowledged.
+ // DevTools protocol.
params.SetBoolean("ignoreCache", false);
return client_->SendCommand("Page.reload", params);
}

Powered by Google App Engine
This is Rietveld 408576698