chrome/common/extensions/docs/examples/api/devtools/inspectedWindow/chrome-preprocessor/Panel/PreprocessorPanel.js - Issue 1867523002: Rename ignore_cache and ignoreCache to bypass* unless it affects API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/examples/api/devtools/inspectedWindow/chrome-preprocessor/Panel/PreprocessorPanel.js

Issue 1867523002: Rename ignore_cache and ignoreCache to bypass* unless it affects API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/devtools/inspected_window.json ('K') | « chrome/common/extensions/api/devtools/inspected_window.json ('k') | chrome/test/chromedriver/chrome/web_view_impl.cc » ('j') | chrome/test/chromedriver/chrome/web_view_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/examples/api/devtools/inspectedWindow/chrome-preprocessor/Panel/PreprocessorPanel.js

diff --git a/chrome/common/extensions/docs/examples/api/devtools/inspectedWindow/chrome-preprocessor/Panel/PreprocessorPanel.js b/chrome/common/extensions/docs/examples/api/devtools/inspectedWindow/chrome-preprocessor/Panel/PreprocessorPanel.js

index 2cdf41ab5195de061549e8564784bcef3c7e51f7..eb3e28e79f22c23c00ee85b38ae30da2a3ac08d2 100644

--- a/chrome/common/extensions/docs/examples/api/devtools/inspectedWindow/chrome-preprocessor/Panel/PreprocessorPanel.js

+++ b/chrome/common/extensions/docs/examples/api/devtools/inspectedWindow/chrome-preprocessor/Panel/PreprocessorPanel.js

@@ -26,6 +26,8 @@ function extractPreprocessedFiles(onExtracted) {

function reloadWithPreprocessor(injectedScript) {

var options = {

+ // TODO(toyoshim): Check if this ignoreCache shouldn't be changed for

Takashi Toyoshima 2016/04/06 09:36:23 I left some TODOs like this where I think the |ign

dgozman 2016/04/06 15:44:19 This is an example of public API usage, and should

Takashi Toyoshima 2016/04/08 04:50:54 Ah, yes. I just added TODOs for reviews, and will

+ // DevTools API for Extensions.

ignoreCache: true,

userAgent: undefined,

injectedScript: '(' + injectedScript + ')()',