[remoting android] Add native library and JNI glue for host.

[remoting android] Add native library and JNI glue for host.

BUG=602355
Committed: https://crrev.com/14545df94f66e4e2c3973b8f5ebb9e94108a4621
Cr-Commit-Position: refs/heads/master@{#386439}

[Lambros, 2016-04-06 00:23:21]

lambroslambrou@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Sergey Ulanov, 2016-04-07 00:41:06]

Do we have a bug for this work? If not, can you please open one? Then add BUG=

LGTM

https://codereview.chromium.org/1867433002/diff/1/remoting/android/host/src/o...
File remoting/android/host/src/org/chromium/chromoting/host/jni/Host.java
(right):

https://codereview.chromium.org/1867433002/diff/1/remoting/android/host/src/o...
remoting/android/host/src/org/chromium/chromoting/host/jni/Host.java:26: if
(sLoaded) return;
Do we need synchronization here?
Or if we don't except it to be called multiple times then this can be just an
assert.

[Lambros, 2016-04-11 18:26:21]

Description was changed from

==========
[remoting android] Add native library and JNI glue for host.
==========

to

==========
[remoting android] Add native library and JNI glue for host.

BUG=602355
==========

[Lambros, 2016-04-11 18:44:47]

BUG= added.

https://codereview.chromium.org/1867433002/diff/1/remoting/android/host/src/o...
File remoting/android/host/src/org/chromium/chromoting/host/jni/Host.java
(right):

https://codereview.chromium.org/1867433002/diff/1/remoting/android/host/src/o...
remoting/android/host/src/org/chromium/chromoting/host/jni/Host.java:26: if
(sLoaded) return;
On 2016/04/07 00:41:06, Sergey Ulanov wrote:
> Do we need synchronization here?
> Or if we don't except it to be called multiple times then this can be just an
> assert.

It's only called during Activity.onCreate() on the main thread. FindBugs hasn't
complained about it :)
AFAIK, there's nothing to prevent Android from re-using the same process for
multiple Activity onCreate()->onDestroy() lifecycles, so I think the flag is
needed.

However, if we move this to the ApplicationContext object (we create a derived
class and register it in our AndroidManifest.xml), that seems to be a true
singleton and we wouldn't need the flag:
http://stackoverflow.com/questions/11490599/can-application-context-be-change...

I'll land this as-is for now. I'll upload a separate CL to propose using the
ApplicationContext here and in the client APK.

[Lambros, 2016-04-11 18:45:19]

The CQ bit was checked by lambroslambrou@chromium.org

[commit-bot: I haz the power, 2016-04-11 18:46:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867433002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867433002/1

[commit-bot: I haz the power, 2016-04-11 19:33:52]

Description was changed from

==========
[remoting android] Add native library and JNI glue for host.

BUG=602355
==========

to

==========
[remoting android] Add native library and JNI glue for host.

BUG=602355
==========

[commit-bot: I haz the power, 2016-04-11 19:33:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-11 19:36:02]

Description was changed from

==========
[remoting android] Add native library and JNI glue for host.

BUG=602355
==========

to

==========
[remoting android] Add native library and JNI glue for host.

BUG=602355

Committed: https://crrev.com/14545df94f66e4e2c3973b8f5ebb9e94108a4621
Cr-Commit-Position: refs/heads/master@{#386439}
==========

[commit-bot: I haz the power, 2016-04-11 19:36:03]

Patchset 1 (id:??) landed as
https://crrev.com/14545df94f66e4e2c3973b8f5ebb9e94108a4621
Cr-Commit-Position: refs/heads/master@{#386439}