Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 1873383002: [remoting android] Move JNI loading to Application.onCreate() (Closed)

Created:
4 years, 8 months ago by Lambros
Modified:
4 years, 8 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@android-host-add-native
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[remoting android] Move JNI loading to Application.onCreate() This moves the JNI loadLibrary() call from the main Activity to the Application context's onCreate(). Since the Application context is global, it will only be initialized once, eliminating the need for a flag. Committed: https://crrev.com/ebd04f842f5111775e6eabb7088a8b0826c849e8 Cr-Commit-Position: refs/heads/master@{#388024}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase, (c) 2016 #

Messages

Total messages: 10 (4 generated)
Lambros
Note this will cause Official builds to fail on startup, until the internal APK is ...
4 years, 8 months ago (2016-04-11 22:13:16 UTC) #2
Sergey Ulanov
lgtm https://codereview.chromium.org/1873383002/diff/1/remoting/android/host/src/org/chromium/chromoting/host/RemotingApplication.java File remoting/android/host/src/org/chromium/chromoting/host/RemotingApplication.java (right): https://codereview.chromium.org/1873383002/diff/1/remoting/android/host/src/org/chromium/chromoting/host/RemotingApplication.java#newcode1 remoting/android/host/src/org/chromium/chromoting/host/RemotingApplication.java:1: // Copyright 2014 The Chromium Authors. All rights ...
4 years, 8 months ago (2016-04-13 00:05:09 UTC) #3
Lambros
https://codereview.chromium.org/1873383002/diff/1/remoting/android/host/src/org/chromium/chromoting/host/RemotingApplication.java File remoting/android/host/src/org/chromium/chromoting/host/RemotingApplication.java (right): https://codereview.chromium.org/1873383002/diff/1/remoting/android/host/src/org/chromium/chromoting/host/RemotingApplication.java#newcode1 remoting/android/host/src/org/chromium/chromoting/host/RemotingApplication.java:1: // Copyright 2014 The Chromium Authors. All rights reserved. ...
4 years, 8 months ago (2016-04-18 20:20:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873383002/20001
4 years, 8 months ago (2016-04-18 20:21:05 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-18 21:09:58 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 21:12:25 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ebd04f842f5111775e6eabb7088a8b0826c849e8
Cr-Commit-Position: refs/heads/master@{#388024}

Powered by Google App Engine
This is Rietveld 408576698