Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1863933002: [remoting android] Add and build host code. (Closed)

Created:
4 years, 8 months ago by Lambros
Modified:
4 years, 8 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@android-host-add-native
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[remoting android] Add and build host code. BUG=602355 Committed: https://crrev.com/51e19b9baa78d3eef889319ba6c49d18d1c22fd7 Cr-Commit-Position: refs/heads/master@{#387103}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Address feeback, use std::unique_ptr #

Patch Set 3 : Exclude start_host and It2Me native messaging host on Android #

Patch Set 4 : Add resources_android.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -22 lines) Patch
M remoting/BUILD.gn View 1 chunk +5 lines, -2 lines 0 comments Download
M remoting/android/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M remoting/host/BUILD.gn View 1 2 2 chunks +8 lines, -1 line 0 comments Download
M remoting/host/android/remoting_host_jni_onload.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A + remoting/host/audio_capturer_android.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A remoting/host/continue_window_android.cc View 1 1 chunk +38 lines, -0 lines 0 comments Download
A remoting/host/curtain_mode_android.cc View 1 1 chunk +38 lines, -0 lines 0 comments Download
A remoting/host/desktop_resizer_android.cc View 1 1 chunk +49 lines, -0 lines 0 comments Download
A remoting/host/disconnect_window_android.cc View 1 1 chunk +35 lines, -0 lines 0 comments Download
M remoting/host/host_details.cc View 1 chunk +7 lines, -3 lines 0 comments Download
A remoting/host/input_injector_android.cc View 1 1 chunk +57 lines, -0 lines 0 comments Download
M remoting/host/it2me/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
A remoting/host/local_input_monitor_android.cc View 1 1 chunk +30 lines, -0 lines 0 comments Download
M remoting/host/me2me_desktop_environment.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/host/pairing_registry_delegate_android.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M remoting/host/policy_watcher.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + remoting/host/resources_android.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/resources_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/host/security_key/gnubby_auth_handler_android.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/host/username.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/remoting_enable.gni View 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/remoting_host_srcs.gypi View 1 2 3 9 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (17 generated)
Lambros
This is mostly stub implementations. But there is plenty other fun stuff in there for ...
4 years, 8 months ago (2016-04-06 01:43:26 UTC) #2
Sergey Ulanov
please add BUG= https://codereview.chromium.org/1863933002/diff/1/remoting/host/input_injector_android.cc File remoting/host/input_injector_android.cc (right): https://codereview.chromium.org/1863933002/diff/1/remoting/host/input_injector_android.cc#newcode15 remoting/host/input_injector_android.cc:15: using protocol::TouchEvent; nit: Remove these and ...
4 years, 8 months ago (2016-04-07 00:56:15 UTC) #3
Sergey Ulanov
lgtm once my comments are addressed
4 years, 8 months ago (2016-04-07 00:56:25 UTC) #4
Lambros
https://codereview.chromium.org/1863933002/diff/1/remoting/host/input_injector_android.cc File remoting/host/input_injector_android.cc (right): https://codereview.chromium.org/1863933002/diff/1/remoting/host/input_injector_android.cc#newcode15 remoting/host/input_injector_android.cc:15: using protocol::TouchEvent; On 2016/04/07 00:56:14, Sergey Ulanov wrote: > ...
4 years, 8 months ago (2016-04-12 21:58:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863933002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863933002/40001
4 years, 8 months ago (2016-04-12 21:58:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/49744)
4 years, 8 months ago (2016-04-12 22:31:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863933002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863933002/60001
4 years, 8 months ago (2016-04-12 23:22:42 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863933002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863933002/60001
4 years, 8 months ago (2016-04-12 23:33:19 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/49798)
4 years, 8 months ago (2016-04-13 00:00:06 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863933002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863933002/80001
4 years, 8 months ago (2016-04-13 18:13:11 UTC) #22
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-13 18:51:54 UTC) #24
Sergey Ulanov
lgtm
4 years, 8 months ago (2016-04-13 21:23:40 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863933002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863933002/80001
4 years, 8 months ago (2016-04-13 21:24:03 UTC) #28
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 8 months ago (2016-04-13 21:30:50 UTC) #30
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 21:33:31 UTC) #32
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/51e19b9baa78d3eef889319ba6c49d18d1c22fd7
Cr-Commit-Position: refs/heads/master@{#387103}

Powered by Google App Engine
This is Rietveld 408576698