content/browser/service_worker/service_worker_context_request_handler.h - Issue 1867293004: Set service worker response info data for foreign fetch intercepted fetches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_request_handler.h

Issue 1867293004: Set service worker response info data for foreign fetch intercepted fetches. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ff-check-origin

Patch Set: address comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/foreign_fetch_request_handler.cc ('k') | content/browser/service_worker/service_worker_context_request_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_request_handler.h

diff --git a/content/browser/service_worker/service_worker_context_request_handler.h b/content/browser/service_worker/service_worker_context_request_handler.h

index e86fb8332ae98060c41ee883196571796f4b31df..37b97f01051497ec85ae6b71eeffce4047b4e430 100644

--- a/content/browser/service_worker/service_worker_context_request_handler.h

+++ b/content/browser/service_worker/service_worker_context_request_handler.h

@@ -32,8 +32,6 @@ class CONTENT_EXPORT ServiceWorkerContextRequestHandler

net::NetworkDelegate* network_delegate,

ResourceContext* resource_context) override;

- void GetExtraResponseInfo(ResourceResponseInfo* response_info) const override;

private:

bool ShouldAddToScriptCache(const GURL& url);

bool ShouldReadFromScriptCache(const GURL& url, int64_t* resource_id_out);