Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: content/browser/service_worker/foreign_fetch_request_handler.cc

Issue 1867293004: Set service worker response info data for foreign fetch intercepted fetches. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ff-check-origin
Patch Set: address comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/foreign_fetch_request_handler.cc
diff --git a/content/browser/service_worker/foreign_fetch_request_handler.cc b/content/browser/service_worker/foreign_fetch_request_handler.cc
index 2034266deb008f00ac5cfd24906801543e05a250..59fe4846dfdedca40e239a131337244232f20f80 100644
--- a/content/browser/service_worker/foreign_fetch_request_handler.cc
+++ b/content/browser/service_worker/foreign_fetch_request_handler.cc
@@ -8,6 +8,7 @@
#include "base/macros.h"
#include "content/browser/service_worker/service_worker_context_wrapper.h"
+#include "content/browser/service_worker/service_worker_response_info.h"
#include "content/browser/service_worker/service_worker_url_request_job.h"
#include "content/common/resource_request_body.h"
#include "content/common/service_worker/service_worker_utils.h"
@@ -102,6 +103,7 @@ net::URLRequestJob* ForeignFetchRequestHandler::MaybeCreateJob(
net::NetworkDelegate* network_delegate,
ResourceContext* resource_context) {
ClearJob();
+ ServiceWorkerResponseInfo::ResetDataForRequest(request);
if (!context_) {
// We can't do anything other than to fall back to network.
@@ -204,23 +206,11 @@ void ForeignFetchRequestHandler::DidFindRegistration(
job->ForwardToServiceWorker();
}
-void ForeignFetchRequestHandler::OnPrepareToRestart(
- base::TimeTicks service_worker_start_time,
- base::TimeTicks service_worker_ready_time) {
+void ForeignFetchRequestHandler::OnPrepareToRestart() {
use_network_ = true;
ClearJob();
}
-void ForeignFetchRequestHandler::OnStartCompleted(
- bool was_fetched_via_service_worker,
- bool was_fallback_required,
- const GURL& original_url_via_service_worker,
- blink::WebServiceWorkerResponseType response_type_via_service_worker,
- base::TimeTicks service_worker_start_time,
- base::TimeTicks service_worker_ready_time,
- bool response_is_in_cache_storage,
- const std::string& response_cache_storage_cache_name) {}
-
ServiceWorkerVersion* ForeignFetchRequestHandler::GetServiceWorkerVersion(
ServiceWorkerMetrics::URLRequestJobResult* result) {
// TODO(mek): Figure out what should happen if the active worker changes or

Powered by Google App Engine
This is Rietveld 408576698