content/browser/service_worker/service_worker_context_request_handler.cc - Issue 1867293004: Set service worker response info data for foreign fetch intercepted fetches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_request_handler.cc

Issue 1867293004: Set service worker response info data for foreign fetch intercepted fetches. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ff-check-origin

Patch Set: address comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_context_request_handler.h ('k') | content/browser/service_worker/service_worker_controllee_request_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_request_handler.cc

diff --git a/content/browser/service_worker/service_worker_context_request_handler.cc b/content/browser/service_worker/service_worker_context_request_handler.cc

index c354eae6cd3e70b1c97c0ae37024b753387bbe6a..36d2875f96a41aa976bbdedc181211b96bcdcead 100644

--- a/content/browser/service_worker/service_worker_context_request_handler.cc

+++ b/content/browser/service_worker/service_worker_context_request_handler.cc

@@ -103,15 +103,6 @@ net::URLRequestJob* ServiceWorkerContextRequestHandler::MaybeCreateJob(

return NULL;

}

-void ServiceWorkerContextRequestHandler::GetExtraResponseInfo(

- ResourceResponseInfo* response_info) const {

- response_info->was_fetched_via_service_worker = false;

- response_info->was_fallback_required_by_service_worker = false;

- response_info->original_url_via_service_worker = GURL();

- response_info->response_type_via_service_worker =

- blink::WebServiceWorkerResponseTypeDefault;

bool ServiceWorkerContextRequestHandler::ShouldAddToScriptCache(

const GURL& url) {

// We only write imports that occur during the initial eval.