Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1866663002: Remove unnecessary includes from dom. (Closed)

Created:
4 years, 8 months ago by kochi
Modified:
4 years, 8 months ago
Reviewers:
hayato
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-events_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, Eric Willigers, rjwright, rwlbuis, shans, sof, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary includes from dom. After Oilpan-type migraion, many includes such as wtf/RefPtr.h are no longer necessary. Committed: https://crrev.com/9212b236fe24c252a6f54e6f9d6b2024285e5eaf Cr-Commit-Position: refs/heads/master@{#385428}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -91 lines) Patch
M third_party/WebKit/Source/core/dom/CSSSelectorWatch.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ChildNodeList.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/CompositorProxy.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CrossThreadTask.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMImplementation.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentInit.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentStyleSheetCollector.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ElementDataCache.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/EmptyNodeList.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/IncrementLoadEventDelayCount.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/LiveNodeList.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/MessageChannel.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/MutationCallback.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/MutationObserver.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MutationRecord.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NamedNodeMap.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeFilter.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/NodeIterator.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeIteratorBase.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/NthIndexCache.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/PresentationAttributeStyle.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunner.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptedAnimationController.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StaticNodeList.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleChangeReason.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleSheetCollection.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Touch.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/TreeWalker.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/UserActionElementSet.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElement.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementCallbackInvocation.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementCallbackQueue.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementLifecycleCallbacks.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementMicrotaskDispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementMicrotaskImportStep.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementMicrotaskQueueBase.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementMicrotaskResolutionStep.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementMicrotaskRunQueue.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementRegistrationContext.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementRegistrationContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementScheduler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ElementShadow.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversalTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ShadowRootRareData.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
kochi
PTAL
4 years, 8 months ago (2016-04-06 08:45:18 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866663002/1
4 years, 8 months ago (2016-04-06 08:45:29 UTC) #4
hayato
lgtm
4 years, 8 months ago (2016-04-06 08:48:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1866663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1866663002/1
4 years, 8 months ago (2016-04-06 08:57:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 10:06:07 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 10:07:24 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9212b236fe24c252a6f54e6f9d6b2024285e5eaf
Cr-Commit-Position: refs/heads/master@{#385428}

Powered by Google App Engine
This is Rietveld 408576698