Throw an error early when dump info is used with the startup emitter.

Throw an error early when dump info is used with the startup emitter.

The compiler will crash at the very end of the compilation with a cryptic
error message if dump info is used with the fast startup emitter.

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/c38de336c7d4ef6ab7c26c7bec2419ac8510f414

[Harry Terkelsen, 2016-04-07 17:35:34]

het@google.com changed reviewers:
+ sigmund@google.com

[Harry Terkelsen, 2016-04-07 17:39:01]

https://codereview.chromium.org/1866403002/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/1866403002/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:339: '--dump-info is not supported with the
fast startup emitter');
I considered instead of crashing, just giving a warning and disabling dump-info
in this case, but I saw above that the compiler will crash if --dump-info is
enabled with dart2dart.

I'm open to either approach, let me know what you think

[Siggi Cherem (dart-lang), 2016-04-07 18:24:36]

lgtm

https://codereview.chromium.org/1866403002/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/1866403002/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:339: '--dump-info is not supported with the
fast startup emitter');
On 2016/04/07 17:39:00, Harry Terkelsen wrote:
> I considered instead of crashing, just giving a warning and disabling
dump-info
> in this case, but I saw above that the compiler will crash if --dump-info is
> enabled with dart2dart.
> 
> I'm open to either approach, let me know what you think

fine with either too. This is probably easier to notice, so let's keep it.

[Harry Terkelsen, 2016-04-07 19:38:51]

Description was changed from

==========
Throw an error early when dump info is used with the startup emitter.

The compiler will crash at the very end of the compilation with a cryptic
error message if dump info is used with the fast startup emitter.

BUG=
==========

to

==========
Throw an error early when dump info is used with the startup emitter.

The compiler will crash at the very end of the compilation with a cryptic
error message if dump info is used with the fast startup emitter.

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c38de336c7d4ef6ab7c26c7bec2419ac8510f414
==========

[Harry Terkelsen, 2016-04-07 19:38:53]

Committed patchset #1 (id:1) manually as
c38de336c7d4ef6ab7c26c7bec2419ac8510f414 (presubmit successful).