Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: pkg/compiler/lib/src/compiler.dart

Issue 1866403002: Throw an error early when dump info is used with the startup emitter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.compiler_base; 5 library dart2js.compiler_base;
6 6
7 import 'dart:async' show EventSink, Future; 7 import 'dart:async' show EventSink, Future;
8 8
9 import '../compiler_new.dart' as api; 9 import '../compiler_new.dart' as api;
10 import 'cache_strategy.dart' show CacheStrategy; 10 import 'cache_strategy.dart' show CacheStrategy;
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 useNewSourceInfo: options.useNewSourceInfo); 327 useNewSourceInfo: options.useNewSourceInfo);
328 backend = jsBackend; 328 backend = jsBackend;
329 } else { 329 } else {
330 backend = new dart_backend.DartBackend(this, options.strips, 330 backend = new dart_backend.DartBackend(this, options.strips,
331 multiFile: options.dart2dartMultiFile); 331 multiFile: options.dart2dartMultiFile);
332 if (options.dumpInfo) { 332 if (options.dumpInfo) {
333 throw new ArgumentError('--dump-info is not supported for dart2dart.'); 333 throw new ArgumentError('--dump-info is not supported for dart2dart.');
334 } 334 }
335 } 335 }
336 336
337 if (options.dumpInfo && options.useStartupEmitter) {
338 throw new ArgumentError(
339 '--dump-info is not supported with the fast startup emitter');
Harry Terkelsen 2016/04/07 17:39:00 I considered instead of crashing, just giving a wa
Siggi Cherem (dart-lang) 2016/04/07 18:24:36 fine with either too. This is probably easier to n
340 }
341
337 tasks = [ 342 tasks = [
338 dietParser = new DietParserTask(this, parsing.parserOptions), 343 dietParser = new DietParserTask(this, parsing.parserOptions),
339 scanner = createScannerTask(), 344 scanner = createScannerTask(),
340 serialization = new SerializationTask(this), 345 serialization = new SerializationTask(this),
341 libraryLoader = new LibraryLoaderTask( 346 libraryLoader = new LibraryLoaderTask(
342 this, 347 this,
343 new _ResolvedUriTranslator(this), 348 new _ResolvedUriTranslator(this),
344 new _ScriptLoader(this), 349 new _ScriptLoader(this),
345 new _ElementScanner(scanner), 350 new _ElementScanner(scanner),
346 this.serialization, 351 this.serialization,
(...skipping 1721 matching lines...) Expand 10 before | Expand all | Expand 10 after
2068 _ElementScanner(this.scanner); 2073 _ElementScanner(this.scanner);
2069 void scanLibrary(LibraryElement library) => scanner.scanLibrary(library); 2074 void scanLibrary(LibraryElement library) => scanner.scanLibrary(library);
2070 void scanUnit(CompilationUnitElement unit) => scanner.scan(unit); 2075 void scanUnit(CompilationUnitElement unit) => scanner.scan(unit);
2071 } 2076 }
2072 2077
2073 class _EmptyEnvironment implements Environment { 2078 class _EmptyEnvironment implements Environment {
2074 const _EmptyEnvironment(); 2079 const _EmptyEnvironment();
2075 2080
2076 String valueOf(String key) => null; 2081 String valueOf(String key) => null;
2077 } 2082 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698