Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: pkg/compiler/lib/src/compiler.dart

Issue 1866403002: Throw an error early when dump info is used with the startup emitter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/compiler.dart
diff --git a/pkg/compiler/lib/src/compiler.dart b/pkg/compiler/lib/src/compiler.dart
index 48a3b537d7aef10773d20b7b96ff982dd504b168..3b9632c26b969e8b4e982b1c54db9a81c23887aa 100644
--- a/pkg/compiler/lib/src/compiler.dart
+++ b/pkg/compiler/lib/src/compiler.dart
@@ -334,6 +334,11 @@ abstract class Compiler implements LibraryLoaderListener {
}
}
+ if (options.dumpInfo && options.useStartupEmitter) {
+ throw new ArgumentError(
+ '--dump-info is not supported with the fast startup emitter');
Harry Terkelsen 2016/04/07 17:39:00 I considered instead of crashing, just giving a wa
Siggi Cherem (dart-lang) 2016/04/07 18:24:36 fine with either too. This is probably easier to n
+ }
+
tasks = [
dietParser = new DietParserTask(this, parsing.parserOptions),
scanner = createScannerTask(),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698