Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1866253002: Launch an external app when Chrome cannot handle the URL (Closed)

Created:
4 years, 8 months ago by Changwan Ryu
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Launch an external app when Chrome cannot handle the URL When some third-party app launched Chrome with an intent, and the URL got redirected to another, we try to stay in Chroem unless there is a new intent handler after redirection. The rationale here is that the user has explicitly chosen Chrome over other intent handlers already, and we do not want to bother them any more. However, if the new URL is actually an external protocol, then Chrome cannot handle it anyways. This CL fixes stay-in-Chrome logic and adds a test case. BUG=598546 Review URL: https://codereview.chromium.org/1855853002 Cr-Commit-Position: refs/heads/master@{#385350} (cherry picked from commit 54b7bc3dea8ab099971559538b9ffc50c79f6d8e) Committed: https://chromium.googlesource.com/chromium/src/+/76012c7276fc5734c9691674aed8a60001b53ca8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Changwan Ryu
4 years, 8 months ago (2016-04-07 02:28:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
76012c7276fc5734c9691674aed8a60001b53ca8.

Powered by Google App Engine
This is Rietveld 408576698