Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3173)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java

Issue 1866253002: Launch an external app when Chrome cannot handle the URL (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@2661
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
index c3b55bfc76f004fa89784729e8bf5b57ef90cf92..987e9be25dee23e4fe5f87ba82e3f3745de02b8d 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
@@ -566,6 +566,20 @@ public class ExternalNavigationHandlerTest extends InstrumentationTestCase {
redirectHandler,
OverrideUrlLoadingResult.OVERRIDE_WITH_EXTERNAL_INTENT,
START_ACTIVITY);
+ // Do not ignore if a new intent cannot be handled by Chrome.
+ redirectHandler.updateIntent(fooIntent);
+ redirectHandler.updateNewUrlLoading(transTypeLinkFromIntent, false, false, 0, 0);
+ redirectHandler.updateNewUrlLoading(transTypeLinkFromIntent, true, false, 0, 0);
+ check("intent://myownurl",
+ NO_REFERRER,
+ NORMAL_PROFILE,
+ transTypeLinkFromIntent,
+ REDIRECT,
+ true,
+ false,
+ redirectHandler,
+ OverrideUrlLoadingResult.OVERRIDE_WITH_EXTERNAL_INTENT,
+ START_ACTIVITY);
}
@SmallTest
@@ -1217,6 +1231,10 @@ public class ExternalNavigationHandlerTest extends InstrumentationTestCase {
return list;
}
}
+ if (intent.getDataString().startsWith("http://")
+ || intent.getDataString().startsWith("https://")) {
+ list.add(newResolveInfo("chrome", "chrome"));
+ }
if (intent.getDataString().startsWith("http://m.youtube.com")
|| intent.getDataString().startsWith("http://youtube.com")) {
list.add(newResolveInfo("youtube", "youtube"));
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698