Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1855853002: Launch an external app when Chrome cannot handle the URL (Closed)

Created:
4 years, 8 months ago by Changwan Ryu
Modified:
4 years, 8 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Launch an external app when Chrome cannot handle the URL When some third-party app launched Chrome with an intent, and the URL got redirected to another, we try to stay in Chroem unless there is a new intent handler after redirection. The rationale here is that the user has explicitly chosen Chrome over other intent handlers already, and we do not want to bother them any more. However, if the new URL is actually an external protocol, then Chrome cannot handle it anyways. This CL fixes stay-in-Chrome logic and adds a test case. BUG=598546 Committed: https://crrev.com/54b7bc3dea8ab099971559538b9ffc50c79f6d8e Cr-Commit-Position: refs/heads/master@{#385350}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Changwan Ryu
4 years, 8 months ago (2016-04-04 02:43:12 UTC) #2
Ted C
lgtm
4 years, 8 months ago (2016-04-05 16:31:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855853002/1
4 years, 8 months ago (2016-04-05 23:55:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 00:38:57 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 00:39:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54b7bc3dea8ab099971559538b9ffc50c79f6d8e
Cr-Commit-Position: refs/heads/master@{#385350}

Powered by Google App Engine
This is Rietveld 408576698