Don't persist plugins across reattach for widget updates.

Don't persist plugins across reattach for widget updates.

HTMLPluginElement::lazyReattachIfNeeded() is called for changes where we
expect the plugin to be re-initialized. For instance, if the type or
data attributes changes on <object>. In theory, a detach() as part of a
plugin-persisting lazy re-attach done previously may already have put
the plugin widget into the persisted plugin widget member. In that case
we will return early from detach() which is why we're resetting the
persisted widget in lazyReattachIfNeeded() instead of handling it in
detach().

R=esprehn@chromium.org
BUG=567329
Committed: https://crrev.com/2c26b87586f57a0b3d4ce5aca1077b36d406c7d3
Cr-Commit-Position: refs/heads/master@{#385590}

[rune, 2016-04-06 21:33:15]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 21:34:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866153002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866153002/1

[esprehn, 2016-04-06 23:04:38]

lgtm

[commit-bot: I haz the power, 2016-04-06 23:40:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 23:40:14]

Dry run: This issue passed the CQ dry run.

[rune, 2016-04-06 23:49:04]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-04-06 23:50:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866153002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866153002/1

[commit-bot: I haz the power, 2016-04-06 23:57:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-06 23:58:08]

Description was changed from

==========
Don't persist plugins across reattach for widget updates.

HTMLPluginElement::lazyReattachIfNeeded() is called for changes where we
expect the plugin to be re-initialized. For instance, if the type or
data attributes changes on <object>. In theory, a detach() as part of a
plugin-persisting lazy re-attach done previously may already have put
the plugin widget into the persisted plugin widget member. In that case
we will return early from detach() which is why we're resetting the
persisted widget in lazyReattachIfNeeded() instead of handling it in
detach().

R=esprehn@chromium.org
BUG=567329
==========

to

==========
Don't persist plugins across reattach for widget updates.

HTMLPluginElement::lazyReattachIfNeeded() is called for changes where we
expect the plugin to be re-initialized. For instance, if the type or
data attributes changes on <object>. In theory, a detach() as part of a
plugin-persisting lazy re-attach done previously may already have put
the plugin widget into the persisted plugin widget member. In that case
we will return early from detach() which is why we're resetting the
persisted widget in lazyReattachIfNeeded() instead of handling it in
detach().

R=esprehn@chromium.org
BUG=567329

Committed: https://crrev.com/2c26b87586f57a0b3d4ce5aca1077b36d406c7d3
Cr-Commit-Position: refs/heads/master@{#385590}
==========

[commit-bot: I haz the power, 2016-04-06 23:58:09]

Patchset 1 (id:??) landed as
https://crrev.com/2c26b87586f57a0b3d4ce5aca1077b36d406c7d3
Cr-Commit-Position: refs/heads/master@{#385590}