Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

Issue 1866153002: Don't persist plugins across reattach for widget updates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/plugins/plugin-reload-data-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de) 4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de)
5 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. 5 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 615 matching lines...) Expand 10 before | Expand all | Expand 10 after
626 return false; 626 return false;
627 } 627 }
628 628
629 bool HTMLPlugInElement::useFallbackContent() const 629 bool HTMLPlugInElement::useFallbackContent() const
630 { 630 {
631 return openShadowRoot(); 631 return openShadowRoot();
632 } 632 }
633 633
634 void HTMLPlugInElement::lazyReattachIfNeeded() 634 void HTMLPlugInElement::lazyReattachIfNeeded()
635 { 635 {
636 if (!useFallbackContent() && needsWidgetUpdate() && layoutObject() && !isIma geType()) 636 if (!useFallbackContent() && needsWidgetUpdate() && layoutObject() && !isIma geType()) {
637 lazyReattachIfAttached(); 637 lazyReattachIfAttached();
638 setPersistedPluginWidget(nullptr);
639 }
638 } 640 }
639 641
640 } // namespace blink 642 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/plugins/plugin-reload-data-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698