third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp - Issue 1866153002: Don't persist plugins across reattach for widget updates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

Issue 1866153002: Don't persist plugins across reattach for widget updates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

index c856856417e4aebab1cce45e6c9c79053095bd63..65303926a7e209d1e38c3755cc22594303932ca0 100644

--- a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

@@ -633,8 +633,10 @@ bool HTMLPlugInElement::useFallbackContent() const

void HTMLPlugInElement::lazyReattachIfNeeded()

{

- if (!useFallbackContent() && needsWidgetUpdate() && layoutObject() && !isImageType())

+ if (!useFallbackContent() && needsWidgetUpdate() && layoutObject() && !isImageType()) {

lazyReattachIfAttached();

+ setPersistedPluginWidget(nullptr);

+ }

}

} // namespace blink

« no previous file with comments | « third_party/WebKit/LayoutTests/plugins/plugin-reload-data-expected.txt ('k') | no next file » | no next file with comments »