third_party/WebKit/Source/modules/permissions/PermissionsCallback.cpp - Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/permissions/PermissionsCallback.cpp

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/permissions/PermissionsCallback.h ('k') | third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/permissions/PermissionsCallback.cpp

diff --git a/third_party/WebKit/Source/modules/permissions/PermissionsCallback.cpp b/third_party/WebKit/Source/modules/permissions/PermissionsCallback.cpp

index 7d967abb6103e381ea5c42d7fd39aa4585798a61..c8507185cfc8873d8150c4d9ea71c69d32de1453 100644

--- a/third_party/WebKit/Source/modules/permissions/PermissionsCallback.cpp

+++ b/third_party/WebKit/Source/modules/permissions/PermissionsCallback.cpp

@@ -17,12 +17,12 @@ PermissionsCallback::PermissionsCallback(ScriptPromiseResolver* resolver, PassOw

ASSERT(m_resolver);

}

-void PermissionsCallback::onSuccess(WebPassOwnPtr<WebVector<WebPermissionStatus>> permissionStatus)

+void PermissionsCallback::onSuccess(std::unique_ptr<WebVector<WebPermissionStatus>> permissionStatus)

{

if (!m_resolver->getExecutionContext() || m_resolver->getExecutionContext()->activeDOMObjectsAreStopped())

return;

- OwnPtr<WebVector<WebPermissionStatus>> statusPtr = permissionStatus.release();

+ OwnPtr<WebVector<WebPermissionStatus>> statusPtr = adoptPtr(permissionStatus.release());

HeapVector<Member<PermissionStatus>> result(m_callerIndexToInternalIndex->size());

// Create the response vector by finding the status for each index by