Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: third_party/WebKit/Source/modules/permissions/PermissionsCallback.h

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/permissions/PermissionsCallback.h
diff --git a/third_party/WebKit/Source/modules/permissions/PermissionsCallback.h b/third_party/WebKit/Source/modules/permissions/PermissionsCallback.h
index 3800a78e4ed2ca609fd1bb2fd57694b8764488f4..a2351c991d2a57338becadd1911e1c033aad3d17 100644
--- a/third_party/WebKit/Source/modules/permissions/PermissionsCallback.h
+++ b/third_party/WebKit/Source/modules/permissions/PermissionsCallback.h
@@ -7,7 +7,6 @@
#include "platform/heap/Handle.h"
#include "public/platform/WebCallbacks.h"
-#include "public/platform/WebPassOwnPtr.h"
#include "public/platform/WebVector.h"
#include "public/platform/modules/permissions/WebPermissionStatus.h"
#include "public/platform/modules/permissions/WebPermissionType.h"
@@ -15,6 +14,8 @@
#include "wtf/PassRefPtr.h"
#include "wtf/RefPtr.h"
+#include <memory>
+
namespace blink {
class ScriptPromiseResolver;
@@ -24,12 +25,12 @@ class ScriptPromiseResolver;
// the callback. It takes a WebPermissionType in its constructor and will pass
// it to the PermissionStatus.
class PermissionsCallback final
- : public WebCallbacks<WebPassOwnPtr<WebVector<WebPermissionStatus>>, void> {
+ : public WebCallbacks<std::unique_ptr<WebVector<WebPermissionStatus>>, void> {
public:
PermissionsCallback(ScriptPromiseResolver*, PassOwnPtr<Vector<WebPermissionType>>, PassOwnPtr<Vector<int>>);
~PermissionsCallback() = default;
- void onSuccess(WebPassOwnPtr<WebVector<WebPermissionStatus>>) override;
+ void onSuccess(std::unique_ptr<WebVector<WebPermissionStatus>>) override;
void onError() override;
private:

Powered by Google App Engine
This is Rietveld 408576698