third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.h - Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.h

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/permissions/PermissionsCallback.cpp ('k') | third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.h

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.h b/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.h

index d460c995d0dbdb89aec4f0f1d64aa085a383a9b0..3da9ed109761d5861f1fc3ed7eb402cca3ec0501 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.h

+++ b/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.h

@@ -21,12 +21,12 @@ struct WebPresentationError;

// the PresentationRequest object that originated the call in its constructor

// and will pass it to the created PresentationConnection.

class PresentationConnectionCallbacks final

- : public WebCallbacks<WebPassOwnPtr<WebPresentationConnectionClient>, const WebPresentationError&> {

+ : public WebCallbacks<std::unique_ptr<WebPresentationConnectionClient>, const WebPresentationError&> {

public:

PresentationConnectionCallbacks(ScriptPromiseResolver*, PresentationRequest*);

~PresentationConnectionCallbacks() override = default;

- void onSuccess(WebPassOwnPtr<WebPresentationConnectionClient>) override;

+ void onSuccess(std::unique_ptr<WebPresentationConnectionClient>) override;

void onError(const WebPresentationError&) override;

private: