content/renderer/push_messaging/push_messaging_dispatcher.cc - Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/push_messaging/push_messaging_dispatcher.cc

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/presentation/presentation_dispatcher.cc ('k') | content/renderer/service_worker/service_worker_context_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/push_messaging/push_messaging_dispatcher.cc

diff --git a/content/renderer/push_messaging/push_messaging_dispatcher.cc b/content/renderer/push_messaging/push_messaging_dispatcher.cc

index 0bd40dc69bb480abe3dd8bf88c1098ff395800a7..1cfc044fb31a24b704dbe8e5c64891b7d977663c 100644

--- a/content/renderer/push_messaging/push_messaging_dispatcher.cc

+++ b/content/renderer/push_messaging/push_messaging_dispatcher.cc

@@ -4,6 +4,7 @@

#include "content/renderer/push_messaging/push_messaging_dispatcher.h"

+#include "base/memory/ptr_util.h"

#include "base/strings/utf_string_conversions.h"

#include "content/child/service_worker/web_service_worker_registration_impl.h"

#include "content/common/push_messaging_messages.h"

@@ -114,8 +115,8 @@ void PushMessagingDispatcher::OnSubscribeFromDocumentSuccess(

subscription_callbacks_.Lookup(request_id);

DCHECK(callbacks);

- callbacks->onSuccess(blink::adoptWebPtr(

- new blink::WebPushSubscription(endpoint, p256dh, auth)));

+ callbacks->onSuccess(

+ base::WrapUnique(new blink::WebPushSubscription(endpoint, p256dh, auth)));

subscription_callbacks_.Remove(request_id);

}