content/renderer/presentation/presentation_dispatcher.cc - Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/presentation/presentation_dispatcher.cc

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/rtc_certificate_generator.cc ('k') | content/renderer/push_messaging/push_messaging_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/presentation/presentation_dispatcher.cc

diff --git a/content/renderer/presentation/presentation_dispatcher.cc b/content/renderer/presentation/presentation_dispatcher.cc

index b3bbbfd5ca7764ab40d04dabd0801ccb4a10a6ed..6536f86324abeba58202e4a890e8b2da718e0806 100644

--- a/content/renderer/presentation/presentation_dispatcher.cc

+++ b/content/renderer/presentation/presentation_dispatcher.cc

@@ -9,6 +9,7 @@

#include <vector>

#include "base/logging.h"

+#include "base/memory/ptr_util.h"

#include "content/common/presentation/presentation_service.mojom.h"

#include "content/public/common/presentation_constants.h"

#include "content/public/common/service_registry.h"

@@ -383,7 +384,7 @@ void PresentationDispatcher::OnSessionCreated(

DCHECK(!session_info.is_null());

presentation_service_->ListenForSessionMessages(session_info.Clone());

- callback->onSuccess(blink::adoptWebPtr(

+ callback->onSuccess(base::WrapUnique(

new PresentationConnectionClient(std::move(session_info))));

}