Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.cc
diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc
index 5f42031b09ec9a134d9416c09bc6c25ca69bc685..44b5ce540e0546e4d293c35332340c5555cda849 100644
--- a/content/renderer/service_worker/service_worker_context_client.cc
+++ b/content/renderer/service_worker/service_worker_context_client.cc
@@ -4,6 +4,7 @@
#include "content/renderer/service_worker/service_worker_context_client.h"
+#include <memory>
#include <utility>
#include "base/lazy_instance.h"
@@ -45,7 +46,6 @@
#include "ipc/ipc_message_macros.h"
#include "third_party/WebKit/public/platform/URLConversion.h"
#include "third_party/WebKit/public/platform/WebMessagePortChannel.h"
-#include "third_party/WebKit/public/platform/WebPassOwnPtr.h"
#include "third_party/WebKit/public/platform/WebReferrerPolicy.h"
#include "third_party/WebKit/public/platform/WebSecurityOrigin.h"
#include "third_party/WebKit/public/platform/WebString.h"
@@ -866,7 +866,7 @@ void ServiceWorkerContextClient::OnDidGetClient(
web_client.reset(new blink::WebServiceWorkerClientInfo(
ToWebServiceWorkerClientInfo(client)));
}
- callbacks->onSuccess(blink::adoptWebPtr(web_client.release()));
+ callbacks->onSuccess(std::move(web_client));
context_->client_callbacks.Remove(request_id);
}
@@ -907,7 +907,7 @@ void ServiceWorkerContextClient::OnOpenWindowResponse(
web_client.reset(new blink::WebServiceWorkerClientInfo(
ToWebServiceWorkerClientInfo(client)));
}
- callbacks->onSuccess(blink::adoptWebPtr(web_client.release()));
+ callbacks->onSuccess(std::move(web_client));
context_->client_callbacks.Remove(request_id);
}
@@ -943,7 +943,7 @@ void ServiceWorkerContextClient::OnFocusClientResponse(
scoped_ptr<blink::WebServiceWorkerClientInfo> web_client (
new blink::WebServiceWorkerClientInfo(
ToWebServiceWorkerClientInfo(client)));
- callback->onSuccess(blink::adoptWebPtr(web_client.release()));
+ callback->onSuccess(std::move(web_client));
} else {
callback->onError(blink::WebServiceWorkerError(
blink::WebServiceWorkerError::ErrorTypeNotFound,
@@ -970,7 +970,7 @@ void ServiceWorkerContextClient::OnNavigateClientResponse(
web_client.reset(new blink::WebServiceWorkerClientInfo(
ToWebServiceWorkerClientInfo(client)));
}
- callbacks->onSuccess(blink::adoptWebPtr(web_client.release()));
+ callbacks->onSuccess(std::move(web_client));
context_->client_callbacks.Remove(request_id);
}
« no previous file with comments | « content/renderer/push_messaging/push_messaging_dispatcher.cc ('k') | content/renderer/usb/web_usb_client_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698