components/test_runner/mock_credential_manager_client.cc - Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/mock_credential_manager_client.cc

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/scheduler/renderer/web_view_scheduler_impl_unittest.cc ('k') | content/child/background_sync/background_sync_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/test_runner/mock_credential_manager_client.cc

diff --git a/components/test_runner/mock_credential_manager_client.cc b/components/test_runner/mock_credential_manager_client.cc

index bda8acd076c6a06e69673e98c6ab4ef77df03a94..a2d2a3c122d332c2d5bda22d6277da9345f99bf4 100644

--- a/components/test_runner/mock_credential_manager_client.cc

+++ b/components/test_runner/mock_credential_manager_client.cc

@@ -4,8 +4,10 @@

#include "components/test_runner/mock_credential_manager_client.h"

+#include <memory>

+#include <utility>

#include "third_party/WebKit/public/platform/WebCredential.h"

-#include "third_party/WebKit/public/platform/WebPassOwnPtr.h"

namespace test_runner {

@@ -52,7 +54,7 @@ void MockCredentialManagerClient::dispatchGet(

if (error_ != blink::WebCredentialManagerNoError)

callbacks->onError(error_);

else

- callbacks->onSuccess(adoptWebPtr(credential_.release()));

+ callbacks->onSuccess(std::move(credential_));

delete callbacks;

}