content/child/background_sync/background_sync_provider.cc - Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/background_sync/background_sync_provider.cc

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/test_runner/mock_credential_manager_client.cc ('k') | content/child/permissions/permission_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/background_sync/background_sync_provider.cc

diff --git a/content/child/background_sync/background_sync_provider.cc b/content/child/background_sync/background_sync_provider.cc

index 1b97dc872be49176077c28bb163f97c6c1bcd2df..820ebf7fa7cff1d3f5d4a7169295170dddbc5aa2 100644

--- a/content/child/background_sync/background_sync_provider.cc

+++ b/content/child/background_sync/background_sync_provider.cc

@@ -138,7 +138,7 @@ void BackgroundSyncProvider::RegisterCallback(

if (!options.is_null())

result =

mojo::ConvertTo<scoped_ptr<blink::WebSyncRegistration>>(options);

- callbacks->onSuccess(blink::adoptWebPtr(result.release()));

+ callbacks->onSuccess(std::move(result));

break;

case mojom::BackgroundSyncError::NOT_FOUND:

NOTREACHED();

« no previous file with comments | « components/test_runner/mock_credential_manager_client.cc ('k') | content/child/permissions/permission_dispatcher.cc » ('j') | no next file with comments »