components/scheduler/renderer/web_view_scheduler_impl_unittest.cc - Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/scheduler/renderer/web_view_scheduler_impl_unittest.cc

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/scheduler/renderer/web_view_scheduler_impl.cc ('k') | components/test_runner/mock_credential_manager_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/scheduler/renderer/web_view_scheduler_impl_unittest.cc

diff --git a/components/scheduler/renderer/web_view_scheduler_impl_unittest.cc b/components/scheduler/renderer/web_view_scheduler_impl_unittest.cc

index fb3e60a30b07c30bc9858695ed8e7c53c28a8992..fb14d0ad94175f5e3e2b2263d145565beb7bd8d9 100644

--- a/components/scheduler/renderer/web_view_scheduler_impl_unittest.cc

+++ b/components/scheduler/renderer/web_view_scheduler_impl_unittest.cc

@@ -58,16 +58,16 @@ class WebViewSchedulerImplTest : public testing::Test {

};

TEST_F(WebViewSchedulerImplTest, TestDestructionOfFrameSchedulersBefore) {

- blink::WebPassOwnPtr<blink::WebFrameScheduler> frame1(

+ std::unique_ptr<blink::WebFrameScheduler> frame1(

web_view_scheduler_->createFrameScheduler(nullptr));

- blink::WebPassOwnPtr<blink::WebFrameScheduler> frame2(

+ std::unique_ptr<blink::WebFrameScheduler> frame2(

web_view_scheduler_->createFrameScheduler(nullptr));

}

TEST_F(WebViewSchedulerImplTest, TestDestructionOfFrameSchedulersAfter) {

- blink::WebPassOwnPtr<blink::WebFrameScheduler> frame1(

+ std::unique_ptr<blink::WebFrameScheduler> frame1(

web_view_scheduler_->createFrameScheduler(nullptr));

- blink::WebPassOwnPtr<blink::WebFrameScheduler> frame2(

+ std::unique_ptr<blink::WebFrameScheduler> frame2(

web_view_scheduler_->createFrameScheduler(nullptr));

web_view_scheduler_.reset();

}