components/scheduler/renderer/web_view_scheduler_impl.cc - Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/scheduler/renderer/web_view_scheduler_impl.cc

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/scheduler/renderer/web_view_scheduler_impl.h ('k') | components/scheduler/renderer/web_view_scheduler_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/scheduler/renderer/web_view_scheduler_impl.cc

diff --git a/components/scheduler/renderer/web_view_scheduler_impl.cc b/components/scheduler/renderer/web_view_scheduler_impl.cc

index ebef3ac213af8a828b0726014b95a0dd0933c990..cf857ab2430a9cd9b53b845fb6328fba43c58a8b 100644

--- a/components/scheduler/renderer/web_view_scheduler_impl.cc

+++ b/components/scheduler/renderer/web_view_scheduler_impl.cc

@@ -62,10 +62,9 @@ WebViewSchedulerImpl::createWebFrameSchedulerImpl(

return frame_scheduler;

}

-blink::WebPassOwnPtr<blink::WebFrameScheduler>

+std::unique_ptr<blink::WebFrameScheduler>

WebViewSchedulerImpl::createFrameScheduler(blink::BlameContext* blame_context) {

- return blink::adoptWebPtr(

- createWebFrameSchedulerImpl(blame_context).release());

+ return createWebFrameSchedulerImpl(blame_context);

}

void WebViewSchedulerImpl::Unregister(WebFrameSchedulerImpl* frame_scheduler) {