Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1865833002: [generators] Decouple generator resume from fullcodegen. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[generators] Decouple generator resume from fullcodegen. Introduce a ResumeGeneratorTrampoline, which does the actual stack state reconstruction (currently always restores a fullcodegen frame), and introduce appropriate TurboFan builtins for %GeneratorPrototype%.next, %GeneratorPrototype%.return and %GeneratorPrototype%.throw based on this native builtin. Also unify the flooding in case of step-in to always work based on JSFunction and remove the special casing for JSGeneratorObject. R=mstarzinger@chromium.org, neis@chromium.org TBR=rossberg@chromium.org BUG=chromium:513471 LOG=n Committed: https://crrev.com/974721c66131d208571b8759a1caadf7f995c54c Cr-Commit-Position: refs/heads/master@{#35283}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1132 lines, -1006 lines) Patch
M BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M src/arm/builtins-arm.cc View 1 chunk +110 lines, -0 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +107 lines, -0 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/bailout-reason.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 11 chunks +73 lines, -90 lines 0 comments Download
M src/builtins.h View 4 chunks +22 lines, -7 lines 0 comments Download
M src/builtins.cc View 1 chunk +105 lines, -1 line 0 comments Download
M src/code-factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M src/compiler/code-stub-assembler.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/code-stub-assembler.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +3 lines, -1 line 1 comment Download
M src/frames.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/frames.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 3 chunks +10 lines, -111 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 3 chunks +9 lines, -107 lines 0 comments Download
M src/full-codegen/full-codegen.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 3 chunks +10 lines, -99 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 3 chunks +8 lines, -100 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 3 chunks +8 lines, -102 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 3 chunks +9 lines, -99 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +113 lines, -0 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +7 lines, -1 line 0 comments Download
D src/js/generator.js View 1 chunk +0 lines, -119 lines 0 comments Download
M src/js/macros.py View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/builtins-mips.cc View 1 chunk +109 lines, -0 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +110 lines, -0 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/objects.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/parsing/parser.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +3 lines, -6 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +2 lines, -11 lines 0 comments Download
M src/runtime/runtime-generator.cc View 2 chunks +0 lines, -75 lines 0 comments Download
M src/runtime/runtime-internal.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +116 lines, -0 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Benedikt Meurer
4 years, 8 months ago (2016-04-06 06:42:12 UTC) #1
Benedikt Meurer
Michi: PTAL Georg: FYI Andreas: TBR'd for parser search-replace.
4 years, 8 months ago (2016-04-06 06:44:49 UTC) #2
Michael Starzinger
LGTM. I like it. https://codereview.chromium.org/1865833002/diff/1/src/deoptimizer.cc File src/deoptimizer.cc (right): https://codereview.chromium.org/1865833002/diff/1/src/deoptimizer.cc#newcode299 src/deoptimizer.cc:299: bool builtin = code->kind() == ...
4 years, 8 months ago (2016-04-06 08:29:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865833002/1
4 years, 8 months ago (2016-04-06 08:34:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 08:37:31 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/974721c66131d208571b8759a1caadf7f995c54c Cr-Commit-Position: refs/heads/master@{#35283}
4 years, 8 months ago (2016-04-06 08:39:40 UTC) #8
Michael Achenbach
4 years, 8 months ago (2016-04-06 09:58:08 UTC) #9
Message was sent while issue was closed.
Please add skips for tests failing now ignition + win nosnap shared (or fix):
https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%2...

Powered by Google App Engine
This is Rietveld 408576698