Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: src/compiler.cc

Issue 1865833002: [generators] Decouple generator resume from fullcodegen. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index af51d276ce9b40012c27c7a5becce38690ec6004..9d942c6846d203fa59ff6a8ff86f9fbcc84b0787 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -375,14 +375,6 @@ OptimizedCompileJob::Status OptimizedCompileJob::CreateGraph() {
return AbortOptimization(kFunctionBeingDebugged);
}
- // Resuming a suspended frame is not supported by Crankshaft/TurboFan.
- if (info()->shared_info()->HasBuiltinFunctionId() &&
- (info()->shared_info()->builtin_function_id() == kGeneratorObjectNext ||
- info()->shared_info()->builtin_function_id() == kGeneratorObjectReturn ||
- info()->shared_info()->builtin_function_id() == kGeneratorObjectThrow)) {
- return AbortOptimization(kGeneratorResumeMethod);
- }
-
// Limit the number of times we try to optimize functions.
const int kMaxOptCount =
FLAG_deopt_every_n_times == 0 ? FLAG_max_opt_count : 1000;
@@ -801,14 +793,6 @@ bool UseIgnition(CompilationInfo* info) {
return false;
}
- // TODO(4681): Resuming a suspended frame is not supported.
- if (info->shared_info()->HasBuiltinFunctionId() &&
- (info->shared_info()->builtin_function_id() == kGeneratorObjectNext ||
- info->shared_info()->builtin_function_id() == kGeneratorObjectReturn ||
- info->shared_info()->builtin_function_id() == kGeneratorObjectThrow)) {
- return false;
- }
-
// Checks whether top level functions should be passed by the filter.
if (info->shared_info()->is_toplevel()) {
Vector<const char> filter = CStrVector(FLAG_ignition_filter);
« no previous file with comments | « src/code-factory.cc ('k') | src/compiler/code-stub-assembler.h » ('j') | src/deoptimizer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698