Issue 1865743002: x86 validator: Implement rewriting "movntps" to "movaps" on x86-32

Issue 1865743002: x86 validator: Implement rewriting "movntps" to "movaps" on x86-32 (Closed)

Created:
4 years, 8 months ago by Mark Seaborn

Modified:
4 years, 8 months ago

Reviewers:
Petr Hosek

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master

Target Ref:
refs/heads/master

Project:
nacl

Visibility:
Public.

x86 validator: Implement rewriting "movntps" to "movaps" on x86-32 We were already doing this rewrite for x86-64. Use of "movntps" on x86-32 appears in the Chrome Web Store. BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=598085 TEST=run_validation_rewrite_test run_rewrite_nontemporals_test run_validation_cache_test Review URL: https://codereview.chromium.org/1837733002 (cherry picked from commit ca352b231f2f448e90549dd5cd09901f49f97cbd) Committed: https://chromium.googlesource.com/native_client/src/native_client/+/fb00463cb1ebd46a46c050101f8b6a6c999d5dc1

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -3 lines)			Patch
M	src/trusted/validator/validation_rewrite_test.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/trusted/validator/validation_rewrite_test_data.S	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/trusted/validator_ragel/dfa_validate_common.c	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/validator/rewrite_nontemporals.c	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (2 generated)

Mark Seaborn

4 years, 8 months ago (2016-04-06 00:18:27 UTC) #3

Message was sent while issue was closed.

FYI, I manually cherry-picked this to branch 2661 (similar to
https://codereview.chromium.org/1863433002).