x86 validator: Implement rewriting "movntq" to "movq" on x86-64

x86 validator: Implement rewriting "movntq" to "movq" on x86-64

We were already doing this rewrite for x86-32.

We had previously checked the Web Store to find all the non-temporal
instructions that we need to handle and rewrite, but it looks like we
missed at least one -- "movntq" is being used.  The use might have
appeared after we did the check.

BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=598085
TEST=run_validation_rewrite_test run_rewrite_nontemporals_test run_validation_cache_test

Review URL: https://codereview.chromium.org/1836633002

(cherry picked from commit fb2c685d12b5a13cdb5b284b0ee1ee3c2080a769)

Committed: https://chromium.googlesource.com/native_client/src/native_client/+/ac55cd02bdfef53201e4685a93e64a65eef8e4cd

[Mark Seaborn, 2016-04-05 23:54:11]

Description was changed from

==========
x86 validator: Implement rewriting "movntq" to "movq" on x86-64

We were already doing this rewrite for x86-32.

We had previously checked the Web Store to find all the non-temporal
instructions that we need to handle and rewrite, but it looks like we
missed at least one -- "movntq" is being used.  The use might have
appeared after we did the check.

BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=598085
TEST=run_validation_rewrite_test run_rewrite_nontemporals_test
run_validation_cache_test

Review URL: https://codereview.chromium.org/1836633002

(cherry picked from commit fb2c685d12b5a13cdb5b284b0ee1ee3c2080a769)
==========

to

==========
x86 validator: Implement rewriting "movntq" to "movq" on x86-64

We were already doing this rewrite for x86-32.

We had previously checked the Web Store to find all the non-temporal
instructions that we need to handle and rewrite, but it looks like we
missed at least one -- "movntq" is being used.  The use might have
appeared after we did the check.

BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=598085
TEST=run_validation_rewrite_test run_rewrite_nontemporals_test
run_validation_cache_test

Review URL: https://codereview.chromium.org/1836633002

(cherry picked from commit fb2c685d12b5a13cdb5b284b0ee1ee3c2080a769)

Committed: https://chromium.googlesource.com/native_client/src/native_client/+/
ac55cd02bdfef53201e4685a93e64a65eef8e4cd
==========

[Mark Seaborn, 2016-04-05 23:54:22]

Description was changed from

==========
x86 validator: Implement rewriting "movntq" to "movq" on x86-64

We were already doing this rewrite for x86-32.

We had previously checked the Web Store to find all the non-temporal
instructions that we need to handle and rewrite, but it looks like we
missed at least one -- "movntq" is being used.  The use might have
appeared after we did the check.

BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=598085
TEST=run_validation_rewrite_test run_rewrite_nontemporals_test
run_validation_cache_test

Review URL: https://codereview.chromium.org/1836633002

(cherry picked from commit fb2c685d12b5a13cdb5b284b0ee1ee3c2080a769)

Committed: https://chromium.googlesource.com/native_client/src/native_client/+/
ac55cd02bdfef53201e4685a93e64a65eef8e4cd
==========

to

==========
x86 validator: Implement rewriting "movntq" to "movq" on x86-64

We were already doing this rewrite for x86-32.

We had previously checked the Web Store to find all the non-temporal
instructions that we need to handle and rewrite, but it looks like we
missed at least one -- "movntq" is being used.  The use might have
appeared after we did the check.

BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=598085
TEST=run_validation_rewrite_test run_rewrite_nontemporals_test
run_validation_cache_test

Review URL: https://codereview.chromium.org/1836633002

(cherry picked from commit fb2c685d12b5a13cdb5b284b0ee1ee3c2080a769)

Committed:
https://chromium.googlesource.com/native_client/src/native_client/+/ac55cd02b...
==========

[Mark Seaborn, 2016-04-06 00:10:41]

mseaborn@chromium.org changed reviewers:
+ phosek@chromium.org

[Mark Seaborn, 2016-04-06 00:10:42]

FYI, I have cherry-picked this to the "2661" branch.

I had to do it manually.  I tried to use drover, but it wanted to push the
change to "master", which was no good.  Or at least, "git cl land" wanted to
push the change to "master" and wouldn't recognise the branch.

drover failed as follows:

$ git drover --branch 2661 --cherry-pick
fb2c685d12b5a13cdb5b284b0ee1ee3c2080a769
...
Issue created. URL: https://codereview.chromium.org/1863433002 (patchset: 1)
Uploading base file for src/trusted/validator/validation_rewrite_test.cc
Uploading base file for src/trusted/validator/validation_rewrite_test_data.S
Uploading base file for src/trusted/validator_ragel/dfa_validate_common.c
Uploading base file for tests/validator/rewrite_nontemporals.c
About to land on 2661. Continue (y/n)? y
Using 50% similarity for rename/copy detection. Override with --similarity.
Base branch "refs/remotes/origin/master" has 89 commits not in this branch.
Run "git merge refs/remotes/origin/master" before attempting to land.
Error: Command 'cl land --bypass-hooks' failed: Command '['git', 'cl', 'land',
'--bypass-hooks']' returned non-zero exit status 1