Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1837733002: x86 validator: Implement rewriting "movntps" to "movaps" on x86-32 (Closed)

Created:
4 years, 9 months ago by Mark Seaborn
Modified:
4 years, 8 months ago
Reviewers:
Petr Hosek
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

x86 validator: Implement rewriting "movntps" to "movaps" on x86-32 We were already doing this rewrite for x86-64. Use of "movntps" on x86-32 appears in the Chrome Web Store. BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=598085 TEST=run_validation_rewrite_test run_rewrite_nontemporals_test run_validation_cache_test Committed: https://chromium.googlesource.com/native_client/src/native_client/+/ca352b231f2f448e90549dd5cd09901f49f97cbd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M src/trusted/validator/validation_rewrite_test.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M src/trusted/validator/validation_rewrite_test_data.S View 1 chunk +8 lines, -0 lines 0 comments Download
M src/trusted/validator_ragel/dfa_validate_common.c View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/validator/rewrite_nontemporals.c View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Mark Seaborn
4 years, 9 months ago (2016-03-28 03:45:59 UTC) #2
Petr Hosek
lgtm
4 years, 8 months ago (2016-03-28 17:52:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837733002/1
4 years, 8 months ago (2016-03-28 18:29:58 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 18:31:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/ca352b231...

Powered by Google App Engine
This is Rietveld 408576698