Issue 186473002: Deprecate named base::SharedMemory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 186473002: Deprecate named base::SharedMemory. (Closed)

Created:
6 years, 9 months ago by viettrungluu

Modified:
6 years, 9 months ago

Reviewers:
brettw, sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, gavinp+memory_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Deprecate named base::SharedMemory. It's hardly used and not implemented on various platforms. (More deprecation work here to come.) R=brettw@chromium.org TBR=sky@chromium.org BUG=345734 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255148

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -31 lines)			Patch
M	base/memory/shared_memory.h	View		2 chunks	+13 lines, -8 lines	0 comments	Download
M	base/memory/shared_memory_android.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/memory/shared_memory_posix.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	base/memory/shared_memory_unittest.cc	View		8 chunks	+12 lines, -12 lines	0 comments	Download
M	base/memory/shared_memory_win.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	base/metrics/stats_table.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/service_process_util.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/child/resource_dispatcher_unittest.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

viettrungluu

sky -> OWNERS TBR (for whatever it is under chrome/)

6 years, 9 months ago (2014-03-05 21:12:42 UTC) #3

viettrungluu

6 years, 9 months ago (2014-03-05 21:14:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r255148 (presubmit successful).